Code quality

Author: Lucas Belo

services/tasks_api/create_dynamodb_locally.py

@@ -0,0 +1,32 @@
+import os
+
+import boto3
+
+client = boto3.client("dynamodb", endpoint_url=os.getenv("DYNAMODB_URL"))
+table_name = os.getenv("TABLE_NAME")
+client.create_table(
+    AttributeDefinitions=[
+        {"AttributeName": "PK", "AttributeType": "S"},
+        {"AttributeName": "SK", "AttributeType": "S"},
+        {"AttributeName": "GS1PK", "AttributeType": "S"},
+        {"AttributeName": "GS1SK", "AttributeType": "S"},
+    ],
+    TableName=table_name,
+    KeySchema=[
+        {"AttributeName": "PK", "KeyType": "HASH"},
+        {"AttributeName": "SK", "KeyType": "RANGE"},
+    ],
+    BillingMode="PAY_PER_REQUEST",
+    GlobalSecondaryIndexes=[
+        {
+            "IndexName": "GS1",
+            "KeySchema": [
+                {"AttributeName": "GS1PK", "KeyType": "HASH"},
+                {"AttributeName": "GS1SK", "KeyType": "RANGE"},
+            ],
+            "Projection": {
+                "ProjectionType": "ALL",
+            },
+        },
+    ],
+)

services/tasks_api/main.py

@@ -9,7 +9,7 @@
 
 from config import Config
 from models import Task
-from schemas import APITask, APITaskList, CreateTask, CloseTask
+from schemas import APITask, APITaskList, CloseTask, CreateTask
 from store import TaskStore
 
 app = FastAPI()
@@ -58,7 +58,7 @@ def open_tasks(
     user_email: str = Depends(get_user_email),
     task_store: TaskStore = Depends(get_task_store),
 ):
-    results=task_store.list_open(owner=user_email)
+    results = task_store.list_open(owner=user_email)
     print("Results: ", results)
     return APITaskList(results=results)
 
@@ -84,4 +84,4 @@ def closed_tasks(
     user_email: str = Depends(get_user_email),
     task_store: TaskStore = Depends(get_task_store),
 ):
-    return APITaskList(results=task_store.list_closed(owner=user_email))
+    return APITaskList(results=task_store.list_closed(owner=user_email))

services/tasks_api/models.py

@@ -18,7 +18,6 @@ class Task:
     @classmethod
     def create(cls, id_, title, owner):
         return cls(id_, title, TaskStatus.OPEN, owner)
-    
 
     def close(self):
         self.status = TaskStatus.CLOSED

services/tasks_api/tests.py

@@ -174,14 +174,11 @@ def test_list_closed_tasks(client, user_email, id_token):
         headers={"Authorization": id_token},
     )
 
-    response = client.get(
-        "/api/closed-tasks",
-        headers={"Authorization": id_token}
-    )
+    response = client.get("/api/closed-tasks", headers={"Authorization": id_token})
     body = response.json()
 
     assert response.status_code == status.HTTP_200_OK
     assert body["results"][0]["id"]
     assert body["results"][0]["title"] == title
     assert body["results"][0]["owner"] == user_email
-    assert body["results"][0]["status"] == TaskStatus.CLOSED
+    assert body["results"][0]["status"] == TaskStatus.CLOSED