Adjust to Mike's suggestion, simplify code, bump MC version to 1.21.10

Author: Jakubk15

build.gradle.kts

@@ -20,7 +20,7 @@ repositories {
 
 dependencies {
     // minecraft development api
-    compileOnly("io.papermc.paper:paper-api:1.21.8-R0.1-SNAPSHOT")
+    compileOnly("io.papermc.paper:paper-api:1.21.10-R0.1-SNAPSHOT")
     paperLibrary("dev.rollczi:litecommands-bukkit:3.10.6")
     paperLibrary("dev.rollczi:litecommands-adventure:3.10.6")
 
@@ -109,7 +109,7 @@ tasks.withType<JavaCompile> {
 
 tasks {
     runServer {
-        minecraftVersion("1.21.8")
+        minecraftVersion("1.21.10")
         downloadPlugins.modrinth("luckperms", "v5.5.0-bukkit")
     }
 

src/main/java/com/eternalcode/parcellockers/gui/GuiManager.java

@@ -78,6 +78,7 @@ public void sendParcel(Player sender, Parcel parcel, List<ItemStack> items) {
                         this.parcelService,
                         this.deliveryManager
                     );
+                    this.itemStorageManager.delete(sender.getUniqueId());
 
                     this.scheduler.runLaterAsync(task, delay);
                 });

src/main/java/com/eternalcode/parcellockers/gui/implementation/locker/SendingGui.java

@@ -244,8 +244,6 @@ public void show(Player player) {
                 );
 
                 this.guiManager.sendParcel(player, parcel, result.items());
-                this.guiManager.deleteItemStorage(player.getUniqueId());
-
                 this.gui.close(player);
             }).orTimeout(5, TimeUnit.SECONDS));
 

src/main/java/com/eternalcode/parcellockers/locker/LockerManager.java

@@ -161,7 +161,7 @@ public CompletableFuture<Void> deleteAll(CommandSender sender, NoticeService not
 
     public CompletableFuture<Boolean> isLockerFull(UUID lockerUuid) {
         return this.parcelRepository.countByDestinationLocker(lockerUuid)
-            .thenApply(count -> count >= this.config.settings.maxParcelsPerLocker);
+            .thenApply(count -> count > 0 && count >= this.config.settings.maxParcelsPerLocker);
     }
 
     private void cacheAll() {