Should "sidekiq-unique-jobs" Gem be added as a dependency?

[peteygao]

For this line:

sidekiq_options :unique => :until_executed

If the project doesn't already have the sidekiq-unique-jobs gem, won't this option line just be silently ignored, and uniqueness bugs can creep in?

[mtthgn]

Peter!!

Yes it should, we realized this when we actually tried to remove our dependency from sidekiq unique jobs two weeks ago!

We haven't made the PR yet, but I'll get to that soon.

How are things? Are you using async_cache these days?

[peteygao]

Mattt!!!! 😄

Was about to use async_cache for some really slow API calls (4~5 seconds on average). I remembered the good work that Dirk & Co. did with this gem, so I came by to take a look at the secret sauce (haha). Not using it yet, but it's a likely choice 👍!

I'll shoot you an email and we can chat there!

[vincentwoo]

buy enterprise you jags

[peteygao]

But I'm a poor jag 😞

[dirk]

@mtthgn, @peteygao: I'll fiddle with this this evening and see if I can get it to support both uniqueness options (rather than just sidekiq-unique-jobs).

[dirk]

PR is up at #5 (include Sidekiq Enterprise support for @vincentwoo).