feature: enable unicorn/prefer-set-has rule

Author: gelocraft

eslint-plugin-expensify/no-default-id-values.js

@@ -74,13 +74,13 @@ function create(context) {
         'CONST.DEFAULT_NUMBER_ID}`',
     ];
 
-    disallowedNumberDefaults.forEach((pattern) => {
+    for (const pattern of disallowedNumberDefaults) {
         searchForPatternsAndReport(context, sourceCode, soureCodeStr, pattern, 'disallowedNumberDefault');
-    });
+    }
 
-    disallowedStringDefaults.forEach((pattern) => {
+    for (const pattern of disallowedStringDefaults) {
         searchForPatternsAndReport(context, sourceCode, soureCodeStr, pattern, 'disallowedStringDefault');
-    });
+    }
 
     return {};
 }

eslint-plugin-expensify/no-unstable-hook-defaults.js

@@ -81,22 +81,22 @@ function create(context) {
 
             // Check if the variable declaration is an array pattern (destructuring)
             if (node.id.type === 'ArrayPattern') {
-                node.id.elements.forEach((element) => {
+                for (const element of node.id.elements) {
                     if (!element || element.type !== 'AssignmentPattern') {
-                        return;
+                        continue; // eslint-disable-line no-continue
                     }
                     checkDefaultValue(element.right);
-                });
+                }
             }
 
             // Check if the variable declaration is an object pattern (destructuring)
             if (node.id.type === 'ObjectPattern') {
-                node.id.properties.forEach((property) => {
+                for (const property of node.id.properties) {
                     if (!property || property.type !== 'Property' || property.value.type !== 'AssignmentPattern') {
-                        return;
+                        continue; // eslint-disable-line no-continue
                     }
                     checkDefaultValue(property.value.right);
-                });
+                }
             }
         },
     };

eslint-plugin-expensify/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth.js

@@ -27,17 +27,17 @@ function create(context) {
 
             // Check for 'const {isSmallScreenWidth, ...} = useResponsiveLayout();' pattern
             if (node.id.type === AST_NODE_TYPES.ObjectPattern) {
-                node.id.properties.forEach((property) => {
+                for (const property of node.id.properties) {
                     if (!property.key || property.key.name !== 'isSmallScreenWidth') {
-                        return;
+                        continue; // eslint-disable-line no-continue
                     }
                     context.report({
                         node: property,
                         message:
             CONST.MESSAGE
                 .PREFER_SHOULD_USE_NARROW_LAYOUT_INSTEAD_OF_IS_SMALL_SCREEN_WIDTH,
                     });
-                });
+                }
             }
 
             const scope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope();
@@ -48,7 +48,7 @@ function create(context) {
                 scope.references,
                 reference => reference.identifier.name === variableName,
             );
-            variableUsages.forEach((usage) => {
+            for (const usage of variableUsages) {
                 const parent = usage.identifier.parent;
 
                 // Check for 'const isSmallScreenWidth = var.isSmallScreenWidth;' pattern
@@ -69,19 +69,19 @@ function create(context) {
                     parent.type === AST_NODE_TYPES.VariableDeclarator
         && parent.id.type === AST_NODE_TYPES.ObjectPattern
                 ) {
-                    parent.id.properties.forEach((property) => {
+                    for (const property of parent.id.properties) {
                         if (!property.key || property.key.name !== 'isSmallScreenWidth') {
-                            return;
+                            continue; // eslint-disable-line no-continue
                         }
                         context.report({
                             node: property,
                             message:
               CONST.MESSAGE
                   .PREFER_SHOULD_USE_NARROW_LAYOUT_INSTEAD_OF_IS_SMALL_SCREEN_WIDTH,
                         });
-                    });
+                    }
                 }
-            });
+            }
         },
         MemberExpression(node) {
             // Check for 'const isSmallScreenWidth = useResponsiveLayout().isSmallScreenWidth;' pattern

eslint-plugin-expensify/prefer-type-fest.js

@@ -19,12 +19,12 @@ function create(context) {
     return {
         Program(node) {
             // Find type-fest import declarations
-            node.body.forEach((statement) => {
+            for (const statement of node.body) {
                 if (statement.type !== 'ImportDeclaration' || statement.source.value !== 'type-fest') {
-                    return;
+                    continue; // eslint-disable-line no-continue
                 }
                 typeFestImport = statement;
-            });
+            }
         },
         TSIndexedAccessType(node) {
             const objectType = node.objectType;

rules/unicorn.js

@@ -13,6 +13,7 @@ const config = defineConfig([{
 
     rules: {
         'unicorn/prefer-set-has': 'error',
+        'unicorn/no-array-for-each': 'error',
 
         // Enforce that .find or .findLast are used instead of .filter
         // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-array-find.md