From 6ceb45b189c9c3283bfc2af99cb7de80e3ee5d72 Mon Sep 17 00:00:00 2001 From: yuangwang Date: Fri, 22 Nov 2024 14:05:11 -0600 Subject: [PATCH 1/3] fix angular19 --- packages/@apphosting/adapter-angular/src/interface.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@apphosting/adapter-angular/src/interface.ts b/packages/@apphosting/adapter-angular/src/interface.ts index 1605b31f..46424eb5 100644 --- a/packages/@apphosting/adapter-angular/src/interface.ts +++ b/packages/@apphosting/adapter-angular/src/interface.ts @@ -63,5 +63,5 @@ export const buildManifestSchema = z.object({ server: z.optional(url), browser: url, }), - prerenderedRoutes: z.optional(z.string().array()), + prerenderedRoutes: z.optional(z.union([z.string().array(), z.object({})])), }); From 51ce768c95ce22323c495ca41bfecab1146a8cd2 Mon Sep 17 00:00:00 2001 From: yuangwang Date: Fri, 22 Nov 2024 14:53:49 -0600 Subject: [PATCH 2/3] remove unused fields --- packages/@apphosting/adapter-angular/src/interface.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/@apphosting/adapter-angular/src/interface.ts b/packages/@apphosting/adapter-angular/src/interface.ts index 46424eb5..15f4b858 100644 --- a/packages/@apphosting/adapter-angular/src/interface.ts +++ b/packages/@apphosting/adapter-angular/src/interface.ts @@ -63,5 +63,4 @@ export const buildManifestSchema = z.object({ server: z.optional(url), browser: url, }), - prerenderedRoutes: z.optional(z.union([z.string().array(), z.object({})])), }); From e79243bd07f16c9d9fae52ea23744b3db9dace36 Mon Sep 17 00:00:00 2001 From: yuangwang Date: Fri, 22 Nov 2024 15:00:41 -0600 Subject: [PATCH 3/3] add comment --- packages/@apphosting/adapter-angular/src/interface.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/@apphosting/adapter-angular/src/interface.ts b/packages/@apphosting/adapter-angular/src/interface.ts index 15f4b858..201b7257 100644 --- a/packages/@apphosting/adapter-angular/src/interface.ts +++ b/packages/@apphosting/adapter-angular/src/interface.ts @@ -63,4 +63,7 @@ export const buildManifestSchema = z.object({ server: z.optional(url), browser: url, }), + // angular v18 has an array type and v19 has an object type + // We should uncomment this when we need to use prerenderedRoutes + // prerenderedRoutes: z.optional(z.union([z.string().array(), z.object({})])), });