Fixed bug #8649 : AV when ON CONNECT triggers uses EXECUTE STATEMENT ON EXTERNAL

hvlad · hvlad · commit 7712fce4f919 · 2025-07-12T12:48:54.000+03:00
diff --git a/src/jrd/extds/ExtDS.cpp b/src/jrd/extds/ExtDS.cpp
@@ -231,7 +231,7 @@ Connection* Manager::getConnection(thread_db* tdbb, const string& dataSource,
 		CryptHash ch(att->att_crypt_callback);
 		hash = DefaultHash<UCHAR>::hash(dbName.c_str(), dbName.length(), MAX_ULONG) +
 			   DefaultHash<UCHAR>::hash(dpb.getBuffer(), dpb.getBufferLength(), MAX_ULONG) +
-			   DefaultHash<UCHAR>::hash(ch.getValue(), ch.getLength(), MAX_ULONG);
+			   (ch.isValid() ? DefaultHash<UCHAR>::hash(ch.getValue(), ch.getLength(), MAX_ULONG) : 0);
 
 		while (true)
 		{

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ Connection* Manager::getConnection(thread_db* tdbb, const string& dataSource,`
`231`	`231`	`CryptHash ch(att->att_crypt_callback);`
`232`	`232`	`hash = DefaultHash<UCHAR>::hash(dbName.c_str(), dbName.length(), MAX_ULONG) +`
`233`	`233`	`DefaultHash<UCHAR>::hash(dpb.getBuffer(), dpb.getBufferLength(), MAX_ULONG) +`
`234`		`- DefaultHash<UCHAR>::hash(ch.getValue(), ch.getLength(), MAX_ULONG);`
	`234`	`+ (ch.isValid() ? DefaultHash<UCHAR>::hash(ch.getValue(), ch.getLength(), MAX_ULONG) : 0);`
`235`	`235`
`236`	`236`	`while (true)`
`237`	`237`	`{`