Move blob search logic in Replicator into a new method to prevent code duplication

[Noremos]

No description provided.

[aafemt]

It is better to keep declaration of all overloads in one place so they can be seen with one glance.

[Noremos]

Sorry, I didn't quite understand the remark. The method does not overload anything

[aafemt]

Right, my bad. storeBlobs and storeBlob are different names. Sorry.

[hvlad]

Note, updateRecord() should not put blob into log if it was not changed.
Thus it should have a bit different code.
I can prepare a patch with such improvement (I already done it sometime ago but did not commit yet)

[Noremos]

Note, updateRecord() should not put blob into log if it was not changed. Thus it should have a bit different code. I can prepare a patch with such improvement (I already done it sometime ago but did not commit yet)

I hope the template argument with if constexpr will help split the check without sacrificing performance.

[aafemt]

Note, updateRecord() should not put blob into log if it was not changed.

What it will do if the record is not found on the target side and update to be converted into insert?

[hvlad]

Note, updateRecord() should not put blob into log if it was not changed.

What it will do if the record is not found on the target side and update to be converted into insert?

Good question.

So we have a choice - raise error on replica in (should be very) rare cases or continue to pollute repl logs with duplicated blobs in (should be much more) often cases.

[hvlad]

Note, updateRecord() should not put blob into log if it was not changed. Thus it should have a bit different code. I can prepare a patch with such improvement (I already done it sometime ago but did not commit yet)

I hope the template argument with if constexpr will help split the check without sacrificing performance.

Only if it will not harm code readability.
Don't use all and every feature at all possible places just because it exists.