fix: SqliteAdapter wrong week format fix #81 #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual date format for the SQLiteAdapter is this one:
laravel-trend/src/Adapters/SqliteAdapter.php
Line 15 in 391849c
But this causes an issue as it's a non ISO 8601 date format as stated in the SQLite documentation.
The correct format should be
%G-%V
but is only available after the version 3.46 which is relatively new:In the case where the date format is not recognized (if you run under the ISO 8601 supported version), it returns null as stated in the documentation.
So I used the coalesce method to parse for both format to enforce backward compatibility.