Skip to content

fix: SqliteAdapter wrong week format fix #81 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RomainMazB
Copy link

@RomainMazB RomainMazB commented Feb 10, 2025

The actual date format for the SQLiteAdapter is this one:


But this causes an issue as it's a non ISO 8601 date format as stated in the SQLite documentation.

The correct format should be %G-%V but is only available after the version 3.46 which is relatively new:

  • less than a year
  • not the default version for Ubuntu 24.04
  • not the laravel/sail installed version

In the case where the date format is not recognized (if you run under the ISO 8601 supported version), it returns null as stated in the documentation.

So I used the coalesce method to parse for both format to enforce backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant