Skip to content

Allow JSON columns to be used as the dateColumn in MySQL #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow JSON columns to be used as the dateColumn in MySQL #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e97ae5
Allow JSON columns to be used as the dateColumn in MySQL
SentisMR Feb 10, 2025
03cba6f
Move grammar wrap to Trend + use existing connection
SentisMR Mar 10, 2025
5f07f40
Fix remnant variable name
SentisMR Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Adapters/MySqlAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function format(string $column, string $interval): string
'year' => '%Y',
default => throw new Error('Invalid interval.'),
};

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can checkout this file :)

return "date_format({$column}, '{$format}')";
}
}
5 changes: 4 additions & 1 deletion src/Trend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ protected function getSqlDate(): string
default => throw new Error('Unsupported database driver.'),
};

return $adapter->format($this->dateColumn, $this->interval);
return $adapter->format(
$this->builder->getGrammar()->wrap($this->dateColumn),
$this->interval
);
}

protected function getCarbonDateFormat(): string
Expand Down