Display name instead of number only for contacts within Secure Folder, when enabled

[FrancisH92]

Checklist

• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the request will be dismissed otherwise.
• This issue contains only one feature request.
• I have read and understood the contribution guidelines.

Feature description

The app doesn't show the contacts names when the contact are stored in the secure folder contact book and the option to allow access from outside of the secure folder is checked.
Both Google Message and Samsung Message are showing them.

Why do you want this feature?

I use the secure folder of my Samsung phone and send / receive messages from contacts stored in the address book within the secure folder. For those messages only the phone number is shown making sender identification difficult.

Additional information

Seems "cross-profile contacts" Android API must be accesses?

[FrancisH92]

Hi,
I'm not an expert in Android programming but made some tests : what is possible is to display name and picture of contacts in the secure folder for the messages in the inbox and archive folders. Actually, It is not possible to access to the contacts in the secure folder as this requires a special privilege "INTERACT_ACROSS_USERS_FULL" reserved to preinstalled apps (Google Messages and Samsung Messages). However getting the name and picture from the phone number works (if access to contacts from app outside the secure folder is enabled). That's what I used here.
Here below the patches I applied.

Actually it's just to replace CONTENT_FILTER_URI by ENTERPRISE_CONTENT_FILTER_URI for teh related "PhoneLookup" calls :

diff --git a/app/src/main/kotlin/org/fossify/messages/extensions/Context.kt b/app/src/main/kotlin/org/fossify/messages/extensions/Context.kt
index 8768f140..9e4b47e8 100644
--- a/app/src/main/kotlin/org/fossify/messages/extensions/Context.kt
+++ b/app/src/main/kotlin/org/fossify/messages/extensions/Context.kt
@@ -793,7 +793,7 @@ fun Context.getNameAndPhotoFromPhoneNumber(number: String): NamePhoto {
return NamePhoto(number, null)
}

• val uri = Uri.withAppendedPath(PhoneLookup.CONTENT_FILTER_URI, Uri.encode(number))

• val uri = Uri.withAppendedPath(PhoneLookup.ENTERPRISE_CONTENT_FILTER_URI, Uri.encode(number))
  val projection = arrayOf(
  PhoneLookup.DISPLAY_NAME,
  PhoneLookup.PHOTO_URI

diff --git a/commons/src/main/kotlin/org/fossify/commons/helpers/SimpleContactsHelper.kt b/commons/src/main/kotlin/org/fossify/commons/helpers/SimpleContactsHelper.kt
index 6067278a7..90227671d 100644
--- a/commons/src/main/kotlin/org/fossify/commons/helpers/SimpleContactsHelper.kt
+++ b/commons/src/main/kotlin/org/fossify/commons/helpers/SimpleContactsHelper.kt
@@ -240,7 +240,7 @@ class SimpleContactsHelper(val context: Context) {
return number
}

•    val uri = Uri.withAppendedPath(PhoneLookup.CONTENT_FILTER_URI, Uri.encode(number))
  

•    val uri = Uri.withAppendedPath(PhoneLookup.ENTERPRISE_CONTENT_FILTER_URI, Uri.encode(number))
     val projection = arrayOf(
         PhoneLookup.DISPLAY_NAME
     )
  

@@ -263,7 +263,7 @@ class SimpleContactsHelper(val context: Context) {
return ""
}

•    val uri = Uri.withAppendedPath(PhoneLookup.CONTENT_FILTER_URI, Uri.encode(number))
  

•    val uri = Uri.withAppendedPath(PhoneLookup.ENTERPRISE_CONTENT_FILTER_URI, Uri.encode(number))
     val projection = arrayOf(
         PhoneLookup.PHOTO_URI
     )
  

@@ -434,7 +434,7 @@ class SimpleContactsHelper(val context: Context) {
}

 private fun existsInSystemContacts(number: String): Boolean? {

•    val uri = Uri.withAppendedPath(PhoneLookup.CONTENT_FILTER_URI, Uri.encode(number))
  

•    val uri = Uri.withAppendedPath(PhoneLookup.ENTERPRISE_CONTENT_FILTER_URI, Uri.encode(number))
     return context.contentResolver
         .query(uri, arrayOf(PhoneLookup._ID), null, null, null)
         ?.use { cursor -> cursor.moveToFirst() }