fix: address code-quality review feedback on PR #290

- Use explicit .Where filtering in WarnOnNewAnalysisComponents instead of an implicit-filter foreach
- Remove nullable dereferences in the in-place upgrade tests by asserting on projected analyzer keys and using a non-null local for the analyze response

Author: niemyjski

src/Foundatio.Repositories.Elasticsearch/Configuration/Index.cs

@@ -279,11 +279,8 @@ private void WarnOnNewAnalysisComponents(IEnumerable<string>? desiredKeys, IEnum
             return;
 
         var existing = currentKeys?.ToHashSet() ?? new HashSet<string>();
-        foreach (string key in desiredKeys)
-        {
-            if (!existing.Contains(key))
-                _logger.LogWarning("Adding new {ComponentType} {ComponentKey} to existing index (requires close/reopen)", componentType, key);
-        }
+        foreach (string key in desiredKeys.Where(key => !existing.Contains(key)))
+            _logger.LogWarning("Adding new {ComponentType} {ComponentKey} to existing index (requires close/reopen)", componentType, key);
     }
 
     protected virtual Task DeleteIndexAsync(string name)

tests/Foundatio.Repositories.Elasticsearch.Tests/IndexTests.cs

@@ -662,8 +662,8 @@ public async Task ConfigureAsync_WhenUpgradingInPlaceMultipleTimes_RetainsAllAna
         Assert.NotNull(settings.Settings);
         var analyzers = settings.Settings[index.VersionedName].Settings?.Index?.Analysis?.Analyzers;
         Assert.NotNull(analyzers);
-        Assert.NotNull(analyzers["custom1"]);
-        Assert.NotNull(analyzers["custom2"]);
+        Assert.Contains("custom1", analyzers.Select(a => a.Key));
+        Assert.Contains("custom2", analyzers.Select(a => a.Key));
 
         var fieldMapping = await _client.Indices.GetFieldMappingAsync<Employee>(new Field("upgradedField"), d => d.Indices(index.VersionedName), cancellationToken: TestCancellationToken);
         Assert.True(fieldMapping.IsValidResponse);
@@ -703,10 +703,11 @@ public async Task ConfigureAsync_AfterAddingAnalyzerToExistingIndex_NewAnalyzerI
         }
 
         Assert.NotNull(analyzeResponse);
-        _logger.LogRequest(analyzeResponse);
-        Assert.True(analyzeResponse.IsValidResponse, analyzeResponse.DebugInformation);
-        Assert.NotNull(analyzeResponse.Tokens);
-        var tokens = analyzeResponse.Tokens.Select(t => t.Token).ToList();
+        var response = analyzeResponse;
+        _logger.LogRequest(response);
+        Assert.True(response.IsValidResponse, response.DebugInformation);
+        Assert.NotNull(response.Tokens);
+        var tokens = response.Tokens.Select(t => t.Token).ToList();
         Assert.Equal(new[] { "foo", "bar", "baz" }, tokens);
     }