Disallow setting fp brightness to less than 5 prcnt (grouzen#55)

* Disable setting the FP brightness level to less than 5%

* Run tests in CI pipeline

Author: grouzen

.github/workflows/ci.yaml

@@ -37,6 +37,13 @@ jobs:
       - name: Run Clippy
         run: cargo make lint
 
+      - uses: moonrepo/setup-rust@v1
+        with:
+          bins: cargo-make
+          components: clippy
+      - name: Run tests
+        run: cargo make test
+
   build:
     name: Build
     runs-on: ${{ matrix.os }}

Makefile.toml

@@ -11,9 +11,14 @@ args = ["build"]
 command = "cargo"
 args = ["clippy", "--no-deps", "--all-features", "--all-targets", "--", "-D", "warnings"]
 
+[tasks.test]
+command = "cargo"
+args = ["test"]
+
 [tasks.check-all]
 dependencies = [
     "format",
     "lint",
+    "test",
     "build",
 ]

src/framework/fingerprint.rs

@@ -31,6 +31,18 @@ impl Fingerprint {
         })
     }
 
+    pub fn percentage() -> Self {
+        Self {
+            led_brightness_capability: FpLedBrightnessCapability::Percentage,
+        }
+    }
+
+    pub fn level() -> Self {
+        Self {
+            led_brightness_capability: FpLedBrightnessCapability::Level,
+        }
+    }
+
     pub fn adjust_led_brightness_by_delta(&self, current: u8, delta: i8) -> u8 {
         match self.led_brightness_capability {
             FpLedBrightnessCapability::Level => {
@@ -42,7 +54,12 @@ impl Fingerprint {
             FpLedBrightnessCapability::Percentage => {
                 let new_value = current as i8 + delta;
 
-                new_value as u8
+                // NOTE: disable setting the FP brightness to less than 5%
+                if new_value < 5 {
+                    current
+                } else {
+                    new_value as u8
+                }
             }
         }
     }
@@ -106,3 +123,22 @@ fn adjust_led_brightness_level_by_delta(
         _ => level,
     }
 }
+
+#[cfg(test)]
+mod tests {
+
+    use crate::framework::fingerprint::Fingerprint;
+
+    #[test]
+    fn adjust_led_brightness_by_delta_for_percentage() {
+        let fingerprint = Fingerprint::percentage();
+
+        let result_five = fingerprint.adjust_led_brightness_by_delta(10, -5);
+        let result_six = fingerprint.adjust_led_brightness_by_delta(11, -5);
+        let result_less_than_five = fingerprint.adjust_led_brightness_by_delta(9, -5);
+
+        assert!(result_five == 5);
+        assert!(result_six == 6);
+        assert!(result_less_than_five == 9);
+    }
+}

src/tui.rs

@@ -133,15 +133,13 @@ impl Tui {
 mod tests {
     use std::sync::Arc;
 
-    use framework_lib::chromium_ec::CrosEc;
     use ratatui::crossterm::event::{Event, KeyCode, KeyEvent};
 
     use crate::{app::AppEvent, framework::fingerprint::Fingerprint, tui::Tui};
 
     #[test]
     fn handle_input_internal_quit_event() {
-        let ec = CrosEc::new();
-        let fingerprint = Arc::new(Fingerprint::new(&ec).unwrap());
+        let fingerprint = Arc::new(Fingerprint::percentage());
         let mut tui = Tui::new(fingerprint);
         let event = Event::Key(KeyEvent::from(KeyCode::Char('q')));