Final changes for glvis-4.4 #331
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release version from v4.3.2 to v4.4 in the documentation to reflect the upcoming final release.
- Updated the release badge URL in README.md.
- Updated the release badge URL in CONTRIBUTING.md.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated release badge to indicate version v4.4. |
| CONTRIBUTING.md | Updated release badge to indicate version v4.4. |
Files not reviewed (2)
- CHANGELOG: Language not supported
- vcpkg.json: Language not supported
|
How about #325 ? We could add at least loading of that data collections if not time navigation 🤔 |
|
@najlkin, can you help resolve conflicts? |
|
Fixed, but the visually pleasing alignment of the backslashes depends on the size of Tab 🤤 . With the default size 4 in VSCode, it is nicely aligned now 😄 . |
Made it all spaces, but for the record: tab is clearly 8 spaces |
|
|
||
| - Added support for 1D/2D vector finite elements with 3 range dimensions | ||
| (requires MFEM v4.8). | ||
| - Added support for 1D/2D vector finite elements with 3 range dimensions. |
There was a problem hiding this comment.
@mlstowell and @najlkin -- can we improve this CHANGELOG entry? As it is, it may not be clear what is the difference with the previous one...
There was a problem hiding this comment.
The previous one says scalar elements with 3 vector dimensions. This says vector elements with 3 range dimensions, so they are different to me 🤔 But it is true it is more technical than most of the items around here, but I do not know how to rewrite it keeping the difference clear.
Co-authored-by: Justin Laughlin <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the final changes for the glvis-4.4 release. Key changes include cleaning up unused commented-out code for not-yet-implemented readers, fixing a spelling mistake in a comment, and updating version badges in documentation.
Reviewed Changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| share/palettes-cet.txt | Removed extraneous dash line |
| lib/data_state.hpp | Fixed spelling typo in a comment (“unqiue” → “unique”) |
| lib/coll_reader.hpp & .cpp | Removed outdated commented-out code for unimplemented readers |
| glvis.cpp | Removed commented out options related to unimplemented readers |
| README.md & CONTRIBUTING.md | Updated release badges to reflect version v4.4 |
Files not reviewed (5)
- CHANGELOG: Language not supported
- makefile: Language not supported
- share/Info.cmake.plist.in: Language not supported
- share/Info.plist: Language not supported
- vcpkg.json: Language not supported
|
this branch is now a release candidate for |
📆 Target release date: May 7, 2025
🔴 TODO:
🟢 DONE:
master🟡 After the release:
⚪ Optional: