Commit 103eeaf
authored
feat(stop): add option to only stop server if no players (#4595)
* add no stop if players online
* remove dev message
* monitor will now restart the server if requested earlier
* changed var name
* add npm check to install gamedig
* new line
* add var
* remove from non supported servers
* typo
* word
* move restart request
* change lock file name
* restart and monitor
* refactor(stop): share player-online check + add stoponlyifnoplayersallcommands
- Extract the duplicated gamedig player-count query (previously copy-pasted
in command_stop, command_restart and command_monitor) into a new shared
check_players_online.sh module that sets ${playersonline}; registered in
core_modules.sh.
- Add stoponlyifnoplayersallcommands (default on) so the stoponlyifnoplayers
protection applies to every command that stops the server (e.g. update).
Set to off to limit it to explicit stop/restart, allowing update to stop
the server even while players are online.
- Add the new setting to all game server _default.cfg files.
- Resolve merge with develop (check_gamedig now keeps develop's npm-update
branch plus the 'install Node.js' hint).
* fix(stop): clear stale restart-request lock + warn on failed player query
Addresses Copilot review feedback on #4595:
- command_restart.sh: clear the *-restart-request.lock once a restart
actually proceeds. Previously the lock was only written when postponing
and never removed, so every subsequent monitor run would see the stale
lock and trigger a repeat restart indefinitely. Fixed and verified against
a live server: postponed restart -> monitor executes it and clears the
lock -> a second monitor run no longer restarts.
- check_players_online.sh: if the gamedig query fails for every configured
IP (e.g. gamedig/jq missing), playersonline now still fails open (so a
broken query can't permanently block stop/restart) but prints a clear
warning that the safety check could not run, instead of silently
behaving as if the server were empty.1 parent 51ad60e commit 103eeaf
140 files changed
Lines changed: 628 additions & 1 deletion
File tree
- lgsm
- config-default/config-lgsm
- ahl2server
- ahlserver
- arkserver
- arma3server
- armarserver
- atsserver
- avserver
- bb2server
- bbserver
- bdserver
- bf1942server
- bfvserver
- bmdmserver
- boserver
- bsserver
- btlserver
- btserver
- ccserver
- ckserver
- cmwserver
- cod2server
- cod4server
- codserver
- coduoserver
- codwawserver
- colserver
- cs2server
- csczserver
- csgoserver
- csserver
- cssserver
- ctserver
- dabserver
- dayzserver
- dmcserver
- dodrserver
- dodserver
- dodsserver
- doiserver
- dstserver
- dysserver
- ecoserver
- emserver
- etlserver
- ets2server
- fctrserver
- fofserver
- gmodserver
- hcuserver
- hl2dmserver
- hldmserver
- hldmsserver
- hwserver
- hzserver
- insserver
- inssserver
- iosserver
- jc2server
- jc3server
- jk2server
- kf2server
- kfserver
- l4d2server
- l4dserver
- mcbserver
- mcserver
- mhserver
- mohaaserver
- momserver
- mtaserver
- ndserver
- necserver
- nmrihserver
- ns2cserver
- ns2server
- nsserver
- ohdserver
- onsetserver
- opforserver
- pc2server
- pcserver
- pmcserver
- pvkiiserver
- pwserver
- pzserver
- q2server
- q3server
- q4server
- qlserver
- qwserver
- ricochetserver
- roserver
- rtcwserver
- rustserver
- rwserver
- sampserver
- sbotsserver
- sbserver
- scpslserver
- scpslsmserver
- sdtdserver
- sfcserver
- sfserver
- sof2server
- solserver
- squad44server
- squadserver
- stnserver
- stserver
- svenserver
- terrariaserver
- tf2server
- tfcserver
- tfserver
- tiserver
- ts3server
- tsserver
- tuserver
- twserver
- untserver
- ut2k4server
- ut3server
- ut99server
- utserver
- vhserver
- vintsserver
- vpmcserver
- vsserver
- wetserver
- wfserver
- wmcserver
- wurmserver
- zmrserver
- zpsserver
- modules
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
110 | 114 | | |
111 | 115 | | |
112 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
107 | 111 | | |
108 | 112 | | |
109 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
121 | 125 | | |
122 | 126 | | |
123 | 127 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
106 | 110 | | |
107 | 111 | | |
108 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
98 | 102 | | |
99 | 103 | | |
100 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
98 | 102 | | |
99 | 103 | | |
100 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
111 | 115 | | |
112 | 116 | | |
113 | 117 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
| |||
0 commit comments