refactor: replace unstructured with ResourceGroup type

[Camila-B]

No description provided.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from camila-b. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @Camila-B, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the codebase to transition from using generic unstructured.Unstructured objects to the strongly-typed kptv1alpha1.ResourceGroup object when interacting with inventory resources. This change improves type safety and code maintainability by leveraging the defined API type directly, streamlining operations related to ResourceGroup status updates and size checks across the application.

Highlights

• Type Refactoring: Replaced the use of generic unstructured.Unstructured objects with the specific kptv1alpha1.ResourceGroup type for inventory objects, enhancing type safety and code clarity.
• Code Simplification: Removed the newInventoryUnstructured helper function in applier.go and the Unstructured function in resourcegroup.go, as they are no longer necessary with the direct use of the ResourceGroup type.
• New Utility Function: Introduced a new ObjectKey function within the resourcegroup package to provide a standardized way to generate client.ObjectKey for ResourceGroup objects.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that replaces the use of unstructured.Unstructured with the strongly-typed kptv1alpha1.ResourceGroup. This improves type safety and code readability. I've identified a couple of issues where the TypeMeta is not being correctly handled after fetching the object, which impacts logging and object size calculations. The proposed suggestions should resolve these issues.