Skip to content

[Proposal] Add useHelmSecrets option to helm configΒ #1178

@RoryShively

Description

@RoryShively

I'm rewriting this because it hasn't received enough attention. I originally had proposed to add plugins to the helm config but my proposed implementation was quite complicated. This new proposal has been greatly simplified

I created a PR for helm-secrets that will make integration with skaffold easier.
zendesk/helm-secrets#67

We can create a config option that will use helm-secrets if set to true to decrypt secrets on the fly before deployment. The config might look like this:

apiVersion: skaffold/v1alpha4
kind: Config
build:
  ...
deploy:
  helm:
    releases:
    - name: helm-secrets-test
      chartPath: helm_secrets_test
      valuesFiles:
      - helm_secrets_test/helm_vars/values.yaml
      - helm_secrets_test/helm_vars/secrets.yaml
      useHelmSecrets: true

All that needs to change in the skaffold code is pkg/skaffold/deploy/helm line 110

	args := append([]string{"secrets", "--kube-context", h.kubeContext}, arg...)

Add secrets as an argument if useHelmSecrets is true

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions