From 1ccf991517031bfd6db70b74b0355536a7ae30ff Mon Sep 17 00:00:00 2001 From: SeongChan Lee Date: Thu, 11 Jun 2026 19:13:21 +0900 Subject: [PATCH] fix: use correct module to handle windows path separator --- pkg/skaffold/helm/bin.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/skaffold/helm/bin.go b/pkg/skaffold/helm/bin.go index e5672247910..5242c8d2e06 100644 --- a/pkg/skaffold/helm/bin.go +++ b/pkg/skaffold/helm/bin.go @@ -24,7 +24,7 @@ import ( "io" "os" "os/exec" - "path" + "path/filepath" "regexp" "strings" "time" @@ -121,8 +121,8 @@ func PreparePostRenderer(ctx context.Context, h Client, skaffoldBinary string, h // Take the temporary directory name as unique plugin name. That string is expected to // be safe for direct %s insertion in the YAML Helm plugin manifest. - helmPluginName := path.Base(helmPluginDir) - err = os.WriteFile(path.Join(helmPluginDir, "plugin.yaml"), []byte(fmt.Sprintf(PostRendererTemplate, helmPluginName, skaffoldBinaryAsYaml)), 0644) + helmPluginName := filepath.Base(helmPluginDir) + err = os.WriteFile(filepath.Join(helmPluginDir, "plugin.yaml"), []byte(fmt.Sprintf(PostRendererTemplate, helmPluginName, skaffoldBinaryAsYaml)), 0644) if err != nil && // Don't produce an error in tests that simulate the directory !strings.HasPrefix(PluginInstallDir, "TEMPORARY-TEST-DIR") {