Skip to content

Commit 912f162

Browse files
authored
Merge pull request #784 from HelixDesignSystem/surf-2091-top-nav-design-feedback
feat(topnav): design feedback for top navigation component
2 parents d5d3f48 + 5f01e58 commit 912f162

File tree

2 files changed

+21
-11
lines changed

2 files changed

+21
-11
lines changed

docs/components/topnav/test.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<div id="vue-topNavDemo">
88
<nav id="hxTopNav">
99
<a class="hxTopNavLogo" href="#">
10-
<img src="images/helix-logo.svg" alt="Brand Logo" />
10+
<img src="images/helix-logo.svg" alt="Helix Brand Logo" />
1111
</a>
1212
<div class="hxTopNavMenu hxTopNavOptionMenu">
1313
<hx-disclosure

src/scss/components/topnav/index.scss

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,14 @@
22
@import "vars";
33
@import "./config";
44

5+
/// * ============================= * ///
6+
/// * ====== Top Navigation ====== * ///
7+
/// * ============================= * ///
8+
59
#hxTopNav {
610
background-color: $gray-1000;
711
overflow: hidden;
8-
width: 100%;
12+
width: 100vw;
913

1014
.img-left, // deprecated
1115
.hxTopNavLogo {
@@ -37,7 +41,7 @@
3741
background-color: $gray-800;
3842
height: 2.5rem;
3943
margin: 0.5rem 0 0.5rem 0.5rem;
40-
width: 0.063rem;
44+
width: 1px;
4145
}
4246

4347
.productMenu, // deprecated
@@ -139,14 +143,15 @@
139143
#topnavProductDropdown, // deprecated
140144
.hxTopNavMenu > hx-menu {
141145
background-color: $gray-1000;
142-
border: 0.063rem solid $gray-1000;
146+
border: 1px solid $gray-1000;
143147
color: $gray-0;
144148
min-width: 10.5rem;
145149
padding: 0;
146150
top: 14.5rem;
147151

148152
hx-menuitem {
149153
color: $gray-400;
154+
padding: 1rem 1.25rem;
150155
}
151156

152157
hx-menuitem[disabled] {
@@ -155,7 +160,7 @@
155160
color: $gray-600;
156161
}
157162

158-
hx-menuitem:hover {
163+
hx-menuitem:not(.hxMenuKey):hover {
159164
background-color: $gray-900;
160165
color: $gray-0 !important;
161166
}
@@ -165,7 +170,12 @@
165170
color: $gray-600;
166171
font-size: 0.75rem;
167172
line-height: 1;
173+
padding: 1.25rem 1.25rem 0;
168174
text-transform: none;
175+
176+
&:hover {
177+
cursor: default;
178+
}
169179
}
170180

171181
.menuValue, // deprecated
@@ -180,22 +190,22 @@
180190
.divider, // deprecated
181191
.hxDivider {
182192
border-color: $gray-800;
183-
height: 0.063rem;
193+
height: 1px;
194+
margin: 0.5rem auto;
184195
}
185196

186197
.sectionHeader, // deprecated
187198
> section > header {
188199
padding-bottom: 0.5rem;
189200
}
190201

191-
.sectionBody, // deprecated
192-
> section {
193-
padding: 1rem 1.25rem;
194-
}
195-
196202
.sectionFooter, // deprecated
197203
> section > footer {
204+
padding: 0.5rem 1.25rem 1.25rem;
205+
198206
.hxBtn {
207+
border-color: $cyan-500;
208+
color: $cyan-500;
199209
margin-left: auto;
200210
margin-right: auto;
201211
width: 100%;

0 commit comments

Comments
 (0)