feat: remove newsletter subscribe on newsletter sub (#475)

Author: hoadaniellipniacki

libs/blog-bff/newsletter/src/lib/api.ts

@@ -43,20 +43,16 @@ app.post('/subscribe', async (c) => {
   const { BREVO_API_KEY, BREVO_API_URL } = env(c);
 
   let listIds: number[];
-  let templateId: number;
 
   if (lang === 'pl') {
     listIds = [NewsletterList.PL, NewsletterList.PLNew];
-    templateId = NewsletterTemplate.PL;
   } else {
     listIds = [NewsletterList.EN];
-    templateId = NewsletterTemplate.EN;
   }
 
   try {
     const parsedEmail = v.parse(EmailSchema, newSubscriber);
     const client = new NewsletterClient(BREVO_API_URL, BREVO_API_KEY);
-    let sendTemplate = true;
 
     try {
       const existingContact = await client.getContact(parsedEmail);
@@ -75,9 +71,6 @@ app.post('/subscribe', async (c) => {
           listIds: mergedListIds,
         });
       }
-
-      // Contact is already on the list, we should not send a welcoming template
-      sendTemplate = !alreadySubscribed;
     } catch (err) {
       if (
         typeof err === 'object' &&
@@ -94,23 +87,6 @@ app.post('/subscribe', async (c) => {
       }
     }
 
-    if (sendTemplate) {
-      const template = await client.getTemplate(templateId);
-
-      await client.sendEmail({
-        sender: {
-          id: template.sender.id,
-        },
-        subject: template.subject,
-        htmlContent: template.htmlContent,
-        to: [
-          {
-            email: parsedEmail,
-          },
-        ],
-      });
-    }
-
     return c.json({ success: true }, 200);
   } catch (e) {
     if (e instanceof v.ValiError) {

libs/blog-bff/newsletter/src/lib/newsletter-client.ts

@@ -6,17 +6,6 @@ export class NewsletterClient {
     private _apiKey: string,
   ) {}
 
-  getTemplate(templateId: number): Promise<Template> {
-    return this.request<Template>(`smtp/templates/${templateId}`);
-  }
-
-  sendEmail(dto: SendEmailDto): Promise<void> {
-    return this.request<void>(`smtp/email`, {
-      method: 'POST',
-      body: dto,
-    });
-  }
-
   createContact(contact: NewContactDto): Promise<void> {
     return this.request(`contacts`, {
       method: 'POST',