Skip to content

feat(build): create multiplatform image #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pilartomas
Copy link

@pilartomas pilartomas commented Jul 8, 2025

Signed-off-by: Tomas Pilar [email protected]

Unfortunately, one can't simply enable build multi-platform image without pushing it. This is explained in https://docs.docker.com/reference/cli/docker/buildx/build/#load and further discussed in docker/buildx#65. I had to restructure the pipeline a bit.

@pilartomas pilartomas requested a review from crivetimihai as a code owner July 8, 2025 12:45
@pilartomas pilartomas force-pushed the feat-multiplatform-image branch from 6c1c6c0 to 069eec4 Compare July 8, 2025 13:03
@crivetimihai
Copy link
Member

crivetimihai commented Jul 8, 2025

Thank you, that's awesome! Could you also please take a look at the Makefile to see if some of the targets there need an update as well?

Will review, test and merge this PR after the 0.3.0 release (which gets tagged later today). It will likely be available as a tagged image with 0.3.1 (2025-08-15) or 0.4.0 (2025-08-22)

@pilartomas pilartomas force-pushed the feat-multiplatform-image branch from 069eec4 to 735b8eb Compare July 10, 2025 07:44
@pilartomas
Copy link
Author

pilartomas commented Jul 10, 2025

There seems to be a certificate problem within the arm64 build. I must look into it further.

@pilartomas pilartomas force-pushed the feat-multiplatform-image branch 2 times, most recently from 32481fd to cc64d21 Compare July 10, 2025 10:40
@pilartomas
Copy link
Author

It appearch that the builder stage doesn't work properly for ARM64 setup. The surface error is about missing /bin/sh but resolving that by pre-installing bash only leads to another issue with repositories.

What's strange is that everything builds just fine on my local machine (M1).

I don't think I'll be able to resolve it myself without large changes in the containerfile but that might break some other functionality I am unaware of.

@pilartomas pilartomas force-pushed the feat-multiplatform-image branch from 05dfc1a to cc64d21 Compare July 10, 2025 12:12
@pilartomas pilartomas force-pushed the feat-multiplatform-image branch from cc64d21 to 954c962 Compare July 10, 2025 12:13
@crivetimihai
Copy link
Member

Need to look at this in context of #80

@crivetimihai crivetimihai requested a review from manavgup July 17, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants