use logging, log in sdk (#122)

Signed-off-by: Mandana Vaziri <[email protected]>

Author: vazirim

examples/sdk/hello.pdl

@@ -1,8 +1,8 @@
 text:
 - Hello,
-- model: watsonx/ibm/granite-20b-code-instruct
+- model: watsonx/ibm/granite-34b-code-instruct
   parameters:
     stop:
     - '!'
     include_stop_sequence: true
-- "\n"
+

examples/sdk/hello_dict.py

@@ -4,10 +4,9 @@
     "text": [
         "Hello,",
         {
-            "model": "watsonx/ibm/granite-20b-code-instruct",
+            "model": "watsonx/ibm/granite-34b-code-instruct",
             "parameters": {"stop": ["!"], "include_stop_sequence": True},
         },
-        "\n",
     ]
 }
 

examples/sdk/hello_prog.py

@@ -6,12 +6,11 @@
         text=[
             "Hello,",
             LitellmModelBlock(
-                model="watsonx/ibm/granite-20b-code-instruct",
+                model="watsonx/ibm/granite-34b-code-instruct",
                 parameters=LitellmParameters(
                     stop=["!"], include_stop_sequence=True  # pyright: ignore
                 ),
             ),
-            "\n",
         ]
     )
 )

examples/sdk/hello_str.py

@@ -3,12 +3,11 @@
 HELLO = """
 text:
 - Hello,
-- model: watsonx/ibm/granite-20b-code-instruct
+- model: watsonx/ibm/granite-34b-code-instruct
   parameters:
     stop:
     - '!'
     include_stop_sequence: true
-- "\n"
 """
 
 

src/pdl/pdl.py

@@ -1,5 +1,6 @@
 import argparse
 import json
+import logging
 import os
 import subprocess
 import sys
@@ -23,6 +24,8 @@
 from .pdl_interpreter import InterpreterState, process_prog
 from .pdl_parser import parse_file, parse_str
 
+logger = logging.getLogger(__name__)
+
 
 class InterpreterConfig(TypedDict, total=False):
     """Configuration parameters of the PDL interpreter."""
@@ -62,6 +65,7 @@ def exec_program(
     Returns:
         Return the final result if `output` is set to `"result"`. If set of `all`, it returns a dictionary containing, `result`, `scope`, and `trace`.
     """
+    logging.basicConfig(filename="log.txt", encoding="utf-8", format="", filemode="w")
     config = config or {}
     state = InterpreterState(**config)
     scope = scope or {}

src/pdl/pdl_interpreter.py

@@ -1,4 +1,5 @@
 import json
+import logging
 import re
 import sys
 import types
@@ -78,6 +79,8 @@
 from .pdl_schema_validator import type_check_args, type_check_spec
 from .pdl_utils import messages_concat, messages_to_str, stringify
 
+logger = logging.getLogger(__name__)
+
 
 class PDLRuntimeError(PDLException):
     def __init__(
@@ -123,7 +126,6 @@ def __init__(
 class InterpreterState(BaseModel):
     yield_result: bool = False
     yield_background: bool = False
-    log: list[str] = []
     batch: int = 1
     # batch=0: streaming
     # batch=1: call to generate with `input`
@@ -158,6 +160,7 @@ def generate(
     """
     if log_file is None:
         log_file = "log.txt"
+    logging.basicConfig(filename=log_file, encoding="utf-8", format="", filemode="w")
     try:
         prog, loc = parse_file(pdl_file)
         if state is None:
@@ -184,11 +187,6 @@ def generate(
         print(message, file=sys.stderr)
         if trace_file and exc.trace is not None:
             write_trace(trace_file, exc.trace)
-    finally:
-        if state is not None:
-            with open(log_file, "w", encoding="utf-8") as log_fp:
-                for line in state.log:
-                    log_fp.write(line)
 
 
 def write_trace(
@@ -288,7 +286,7 @@ def step_block(
             yield YieldBackgroundMessage(background)
         if state.yield_result:
             yield YieldResultMessage(result)
-        append_log(state, "Document", background)
+        append_log(state, "Context", background)
     else:
         result, background, scope, trace = yield from step_advanced_block(
             state, scope, block, loc
@@ -1446,5 +1444,5 @@ def get_var(var: str, scope: ScopeType, loc: LocationType) -> Any:
 
 
 def append_log(state: InterpreterState, title, somestring):
-    state.log.append("**********  " + title + "  **********\n")
-    state.log.append(str(somestring) + "\n")
+    logger.warning("**********  %s  **********", title)
+    logger.warning(str(somestring))