Skip to content

Commit f5b3927

Browse files
peterenescufacebook-github-bot
authored andcommitted
fix: Remove additional zones known to cause mismatches (facebookincubator#13899)
Summary: Pull Request resolved: facebookincubator#13899 Removes additional zone ids from timestamp with timezone input generation. This is due to some mismatches between Presto and Velox caused by some underlying library differences. Removing these will help avoid fuzzer flakiness. These may include: Pacific/Rarotonga, +04:30 and America/Bahia_Banderas. Some additional context: T228934191 Reviewed By: kagamiori Differential Revision: D77390143 fbshipit-source-id: 68e1bc8ff969020b55cb5d136b3e308b59909729
1 parent 54aef0b commit f5b3927

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

velox/functions/prestosql/types/fuzzer_utils/TimestampWithTimeZoneInputGenerator.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,19 @@ namespace {
3131
std::vector<int16_t> excludeProblematicTimeZoneIds(
3232
std::vector<int16_t> timeZoneIds) {
3333
static const std::unordered_set<int16_t> kExcludedTimeZones = {
34-
1682, 1683, 1685, 1686, 1687, 1688, 1689, 1691, 1692, 1693, 1697, 1698,
35-
1699, 1700, 1701, 1703, 1704, 1705, 1707, 1708, 1710, 1711, 1713, 1714,
36-
1715, 1716, 1717, 1718, 1719, 1720, 1721, 1722, 1726, 1727, 1728, 1729,
37-
1730, 1731, 1737, 1738, 1753, 1754, 1755, 1757, 1762, 1769, 1773, 1775,
38-
1776, 1780, 1786, 1790, 1796, 1797, 1798, 1804, 1816, 1822, 1827, 1831,
39-
1834, 1837, 1839, 1842, 1845, 1846, 1854, 1860, 1871, 1879, 1881, 1882,
40-
1883, 1883, 1884, 1889, 1891, 1893, 1900, 1903, 1906, 1907, 1908, 1909,
41-
1910, 1919, 1924, 1926, 1933, 1955, 1957, 1962, 1963, 1969, 1994, 1999,
42-
2005, 2006, 2007, 2009, 2049, 2060, 2063, 2065, 2067, 2070, 2071, 2073,
43-
2078, 2081, 2089, 2091, 2093, 2098, 2104, 2107, 2109, 2110, 2111, 2112,
44-
2113, 2116, 2117, 2118, 2119, 2120, 2124, 2130, 2140, 2142, 2150, 2151,
45-
2154, 2159, 2160, 2161, 2162, 2179, 2176, 2177, 2181, 2188, 2195, 2197,
46-
2202, 2204, 2209, 2210, 2233,
34+
1110, 1682, 1683, 1685, 1686, 1687, 1688, 1689, 1691, 1692, 1693, 1697,
35+
1698, 1699, 1700, 1701, 1703, 1704, 1705, 1707, 1708, 1710, 1711, 1713,
36+
1714, 1715, 1716, 1717, 1718, 1719, 1720, 1721, 1722, 1726, 1727, 1728,
37+
1729, 1730, 1731, 1737, 1738, 1753, 1754, 1755, 1757, 1758, 1762, 1769,
38+
1773, 1775, 1776, 1780, 1786, 1790, 1796, 1797, 1798, 1804, 1816, 1822,
39+
1827, 1831, 1834, 1837, 1839, 1842, 1845, 1846, 1854, 1860, 1871, 1879,
40+
1881, 1882, 1883, 1884, 1889, 1891, 1893, 1900, 1903, 1906, 1907, 1908,
41+
1909, 1910, 1919, 1924, 1926, 1933, 1955, 1957, 1962, 1963, 1969, 1994,
42+
1999, 2005, 2006, 2007, 2009, 2049, 2060, 2063, 2065, 2067, 2070, 2071,
43+
2073, 2078, 2081, 2089, 2091, 2093, 2098, 2104, 2107, 2109, 2110, 2111,
44+
2112, 2113, 2116, 2117, 2118, 2119, 2120, 2124, 2130, 2140, 2142, 2150,
45+
2151, 2153, 2154, 2159, 2160, 2161, 2162, 2179, 2176, 2177, 2181, 2188,
46+
2195, 2197, 2202, 2204, 2209, 2210, 2233,
4747
};
4848

4949
timeZoneIds.erase(

0 commit comments

Comments
 (0)