Skip to content

Commit cc2eb54

Browse files
committed
README installation. Function parameter types removed (It is specific to Python 3).
1 parent 872bf53 commit cc2eb54

File tree

2 files changed

+31
-29
lines changed

2 files changed

+31
-29
lines changed

IPGeolocation.py

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,40 +11,40 @@ def __init__(self):
1111
self.__lang = "en"
1212
self.__ipAddresses = []
1313

14-
def setIPAddress(self, ipAddress: str):
14+
def setIPAddress(self, ipAddress):
1515
self.__ipAddress = ipAddress
1616

17-
def getIPAddress(self) -> str:
17+
def getIPAddress(self):
1818
return self.__ipAddress
1919

20-
def setFields(self, fields: str):
20+
def setFields(self, fields):
2121
self.__fields = fields
2222

23-
def getFields(self) -> str:
23+
def getFields(self):
2424
return self.__fields
2525

26-
def setExcludes(self, excludes: str):
26+
def setExcludes(self, excludes):
2727
self.__excludes = excludes
2828

29-
def getExcludes(self) -> str:
29+
def getExcludes(self):
3030
return self.__excludes
3131

32-
def setLang(self, lang: str = "en"):
32+
def setLang(self, lang = "en"):
3333
self.__lang = lang
3434

35-
def getLang(self) -> str:
35+
def getLang(self):
3636
return self.__lang
3737

38-
def setIPAddresses(self, ipAddresses: [] = []):
38+
def setIPAddresses(self, ipAddresses = []):
3939
if len(ipAddresses) > 50:
4040
ValueError("Maximum number of IP addresses for bulk lookup cannot be more than 50.")
4141
else:
4242
self.__ipAddresses = ipAddresses
4343

44-
def getIPAddresses(self) -> []:
44+
def getIPAddresses(self):
4545
return self.__ipAddresses
4646

47-
def getURLParams(self) -> dict:
47+
def getURLParams(self):
4848
urlParams = {}
4949

5050
if self.__ipAddress:
@@ -69,35 +69,35 @@ def __init__(self):
6969
self.__longitude = ""
7070
self.__lang = "en"
7171

72-
def setIPAddress(self, ipAddress: str):
72+
def setIPAddress(self, ipAddress):
7373
self.__ipAddress = ipAddress
7474

75-
def getIPAddress(self) -> str:
75+
def getIPAddress(self):
7676
return self.__ipAddress
7777

78-
def setTimezone(self, timezone: str):
78+
def setTimezone(self, timezone):
7979
self.__timezone = timezone
8080

81-
def getTimezone(self) -> str:
81+
def getTimezone(self):
8282
return self.__timezone
8383

84-
def setCoordinates(self, latitude: str, longitude: str):
84+
def setCoordinates(self, latitude, longitude):
8585
self.__latitude = latitude
8686
self.__longitude = longitude
8787

88-
def getLatitude(self) -> str:
88+
def getLatitude(self):
8989
return self.__latitude
9090

91-
def getLongitude(self) -> str:
91+
def getLongitude(self):
9292
return self.__longitude
9393

94-
def setLang(self, lang: str = "en"):
94+
def setLang(self, lang = "en"):
9595
self.__lang = lang
9696

97-
def getLang(self) -> str:
97+
def getLang(self):
9898
return self.__lang
9999

100-
def getURLParams(self) -> dict:
100+
def getURLParams(self):
101101
urlParams = {}
102102

103103
if self.__ipAddress:
@@ -125,7 +125,7 @@ def __init__(self, apiKey):
125125
def getApiKey(self):
126126
return self.__apiKey
127127

128-
def getGeolocation(self, geolocationParams: GeolocationParams = None):
128+
def getGeolocation(self, geolocationParams = None):
129129
if geolocationParams != None:
130130
if len(geolocationParams.getIPAddresses()) > 0:
131131
requestData = json.dumps({"ips": geolocationParams.getIPAddresses()})
@@ -141,7 +141,7 @@ def getGeolocation(self, geolocationParams: GeolocationParams = None):
141141
else:
142142
return self.__get("ipgeo", self.__urlParams)
143143

144-
def getTimezone(self, timezoneParams: TimezoneParams = None):
144+
def getTimezone(self, timezoneParams = None):
145145
if timezoneParams:
146146
timezoneURLParams = timezoneParams.getURLParams()
147147
timezoneURLParams.update(self.__urlParams)
@@ -150,7 +150,7 @@ def getTimezone(self, timezoneParams: TimezoneParams = None):
150150
else:
151151
return self.__get("timezone", self.__urlParams)
152152

153-
def __get(self, path: str, urlParams: dict = {}) -> dict:
153+
def __get(self, path, urlParams = {}):
154154
url = "https://api.ipgeolocation.io/{0}".format(path)
155155
jsonResponse = None
156156

@@ -167,7 +167,7 @@ def __get(self, path: str, urlParams: dict = {}) -> dict:
167167

168168
return jsonResponse
169169

170-
def __post(self, path: str, requestData: str = "", urlParams: dict = {}) -> []:
170+
def __post(self, path, requestData = "", urlParams = {}):
171171
url = "https://api.ipgeolocation.io/{0}".format(path)
172172
jsonResponse = None
173173

README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@ You need a valid 'IPGeolocation API key' to use this SDK. [Sign up](https://ipge
2020

2121
## System Requirements
2222

23-
Internet connection is required to run this component. This SDK uses ```requests``` module that you need to install before it. Here is the command to install ```requests``` module:
23+
Internet connection is required to run this component. This SDK uses ```requests, json``` modules that you need to install before using it.
2424

25-
```bash
26-
pip install requests --upgrade --user
27-
```
25+
**Note:** This SDK was tested against Python 3.7.1.
26+
27+
## Installation
28+
29+
We haven't published this package in PyPi. Users must download the ```IPGeolocation.py``` file and include in their project to use it.
2830

2931
## Basic Usage
3032

0 commit comments

Comments
 (0)