Merge pull request #5794 from IgniteUI/badge-shadow

refactor(badge): remove `$disable-shadow` property from theme

Author: kdinev

CHANGELOG.md

@@ -24,6 +24,9 @@ Next example shows how you can use the Fluent theme.
 }
 ```
 
+### Theme Changes
+`igx-badge-theme` - Removed the `$disable-shadow` property to mitigate confusion when specifying `$shadow` explicitly.
+
 For more information about the theming please read our [documentation](https://www.infragistics.com/products/ignite-ui-angular/angular/components/themes/index.html)  
 
 ### New Features

projects/igniteui-angular/migrations/update-8_2_0/changes/theme-props.json

@@ -0,0 +1,8 @@
+{
+    "$schema": "../../common/schema/theme-props.schema.json",
+    "changes": [{
+        "name": "$disable-shadow",
+        "remove": true,
+        "owner": "igx-badge-theme"
+    }]
+}

projects/igniteui-angular/src/lib/core/styles/components/badge/_badge-theme.scss

@@ -15,7 +15,6 @@
 /// @param {Color} $text-color [null] - The text color used.
 /// @param {Color} $border-color [null] - The border color used.
 /// @param {Color} $background-color [null] - The background color used.
-/// @param {Bool} $disable-shadow [true] - Sets the badge shadow visibility.
 /// @param {Bool} $disable-border [true] - Sets the badge border visibility.
 /// @param {box-shadow} $shadow [null] - Sets a shadow to be used for the badge.
 /// @param {border-radius} $border-radius [null] - The border radius used for badge component.
@@ -52,7 +51,6 @@
     $background-color: null,
     $shadow: null,
 
-    $disable-shadow: true,
     $disable-border: true
 ) {
     $name: 'igx-badge';
@@ -77,10 +75,6 @@
         $shadow: igx-elevation($elevations, $elevation);
     }
 
-    @if $disable-shadow {
-        $shadow: none;
-    }
-
     @return extend($theme, (
         name: $name,
         palette: $palette,