Skip to content

Commit 89aa9a5

Browse files
authored
Merge branch '8.2.x' into mkirova/fix-5204-master
2 parents 0495047 + 6c348ca commit 89aa9a5

File tree

3 files changed

+19
-2
lines changed

3 files changed

+19
-2
lines changed

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.selection.spec.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -661,6 +661,15 @@ describe('IgxHierarchicalGrid selection #hGrid', () => {
661661
lastRow = childGrid.getRowByIndex(3);
662662
GridSelectionFunctions.verifyRowSelected(lastRow);
663663
});
664+
665+
it('should not select row on expander click.', () => {
666+
const firstRow = hierarchicalGrid.getRowByIndex(0) as IgxHierarchicalRowComponent;
667+
UIInteractions.clickElement(firstRow.expander);
668+
fix.detectChanges();
669+
670+
// check row is not selected
671+
GridSelectionFunctions.verifyRowSelected(firstRow, false);
672+
});
664673
});
665674

666675
describe('Row Selection CRUD', () => {

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-row.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div (click)="toggle()" class="igx-grid__hierarchical-expander" [tabIndex]="tabindex" *ngIf="hasChildren" #expander>
1+
<div (click)="expanderClick($event)" class="igx-grid__hierarchical-expander" [tabIndex]="tabindex" *ngIf="hasChildren" #expander>
22
<ng-container *ngTemplateOutlet="iconTemplate; context: { $implicit: this }">
33
</ng-container>
44
</div>

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-row.component.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,21 @@ export class IgxHierarchicalRowComponent extends IgxRowComponent<IgxHierarchical
8282
return this.grid && this.grid.highlightedRowID === this.rowID;
8383
}
8484

85+
/**
86+
* @hidden
87+
*/
88+
public expanderClick(event) {
89+
event.stopPropagation();
90+
this.toggle();
91+
}
92+
8593
/**
8694
* Toggles the hierarchical row.
8795
* ```typescript
8896
* this.grid1.rowList.first.toggle()
8997
* ```
9098
*/
91-
public toggle(event?) {
99+
public toggle() {
92100
if (this.added) {
93101
return;
94102
}

0 commit comments

Comments
 (0)