Skip to content

Commit d5a6b35

Browse files
committed
fix(for-of): handle null values when getting observed nodes
1 parent c2e8ec5 commit d5a6b35

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1496,7 +1496,7 @@ export class TestIgxForOfDirective<T> extends IgxForOfDirective<T> {
14961496
return super.getBorder(node, dimension);
14971497
}
14981498

1499-
public testGetViewObservedNode(view: any): Element {
1499+
public testGetViewObservedNode(view: any): Element | null {
15001500
return super.getViewObservedNode(view);
15011501
}
15021502

projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -533,14 +533,14 @@ export class IgxForOfDirective<T, U extends T[] = T[]> extends IgxForOfToken<T,U
533533
* hold no element at all, or be torn down before its content is rendered -
534534
* in which case there is nothing to observe and null is returned.
535535
*/
536-
protected getViewObservedNode(view: EmbeddedViewRef<any>): Element {
536+
protected getViewObservedNode(view: EmbeddedViewRef<any> | null | undefined): Element | null {
537537
const rootNodes = view?.rootNodes ?? [];
538-
const elementNode = rootNodes.find(node => node?.nodeType === Node.ELEMENT_NODE);
538+
const elementNode = rootNodes.find(node=> node?.nodeType === Node.ELEMENT_NODE);
539539
const candidate = elementNode ?? rootNodes[0]?.nextElementSibling;
540540
return candidate?.nodeType === Node.ELEMENT_NODE ? candidate : null;
541541
}
542542

543-
protected subscribeToViewObserver(target: Element) {
543+
protected subscribeToViewObserver(target: Element | null) {
544544
if (!target) {
545545
return;
546546
}

0 commit comments

Comments
 (0)