Merge pull request #485 from Instabug/fix/network-log-response-type-v9.1.1

Ali Abdelfattah · web-flow · commit 2b40e930ce2a · 2020-06-23T06:03:14.000+02:00
[Hotfix] Network Logging - Include XHR Response when responseType is `""`
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## master
+
+* Fixes an issue that caused XHR Response not to be logged.
+
 ## v9.1.1 (2020-04-06)
 
 * Fixes an issue with the version name while uploading the sourcemap on Android.
diff --git a/utils/XhrNetworkInterceptor.js b/utils/XhrNetworkInterceptor.js
@@ -88,7 +88,7 @@ const XHRInterceptor = {
                 if (this.responseType === 'blob') {
                   var responseText = await (new Response(this.response)).text();
                   cloneNetwork.responseBody = responseText;
-                } else if (this.responseType === 'text') {
+                } else if (this.responseType === 'text' || this.responseType === '') {
                   cloneNetwork.responseBody = this.response;
                 }
               }

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ const XHRInterceptor = {`
`88`	`88`	`if (this.responseType === 'blob') {`
`89`	`89`	`var responseText = await (new Response(this.response)).text();`
`90`	`90`	`cloneNetwork.responseBody = responseText;`
`91`		`- } else if (this.responseType === 'text') {`
	`91`	`+ } else if (this.responseType === 'text' \|\| this.responseType === '') {`
`92`	`92`	`cloneNetwork.responseBody = this.response;`
`93`	`93`	`}`
`94`	`94`	`}`