Add more tests for graphql

Author: MahmoudMehisen

__tests__/apm.spec.js

@@ -4,7 +4,7 @@
  */
 
 import "react-native";
-import { NativeModules } from "react-native";
+import { NativeModules, Platform } from "react-native";
 import "../jest/mockAPM";
 import APM from "../modules/APM";
 import sinon from "sinon";
@@ -21,6 +21,8 @@ describe("APM Module", () => {
   const endExecutionTrace = sinon.spy(NativeModules.IBGAPM, "endExecutionTrace");
   const startUITrace = sinon.spy(NativeModules.IBGAPM, "startUITrace");
   const endUITrace = sinon.spy(NativeModules.IBGAPM, "endUITrace");
+  const setNetworkLoggingEnabled = sinon.spy(NativeModules.Instabug, "setNetworkLoggingEnabled");
+  const _ibgSleep = sinon.spy(NativeModules.IBGAPM, "ibgSleep");
 
   beforeEach(() => {
     IBGEventEmitter.removeAllListeners();
@@ -38,6 +40,13 @@ describe("APM Module", () => {
     expect(setAppLaunchEnabled.calledOnceWithExactly(true)).toBe(true);
   });
 
+  it("should call the native method setNetworkEnabledIOS", () => {
+    Platform.OS = 'ios';
+    APM.setNetworkEnabledIOS(true);
+
+    expect(setNetworkLoggingEnabled.calledOnceWithExactly(true)).toBe(true);
+  });
+
   it("should call the native method setAutoUITraceEnabled", () => {
     APM.setAutoUITraceEnabled(true);
 
@@ -49,27 +58,27 @@ describe("APM Module", () => {
 
     expect(setLogLevel.calledOnceWithExactly(APM.logLevel.verbose)).toBe(true);
   });
-  
+
   it("should call the native method startExecutionTrace", () => {
     APM.startExecutionTrace("trace");
-    
+
     expect(startExecutionTrace.calledOnceWith("trace")).toBe(true);
   });
-    
+
   it("should call the native method setExecutionTraceAttribute", () => {
     const trace = APM.startExecutionTrace("trace").then(() => {
       trace.setAttribute("key", "value");
       expect(setExecutionTraceAttribute.calledOnceWithExactly(expect.any(String), "key", "value")).toBe(true);
     });
   });
-    
+
   it("should call the native method endExecutionTrace", () => {
     const trace = APM.startExecutionTrace("trace").then(() => {
       trace.end();
       expect(endExecutionTrace.calledOnceWithExactly(expect.any(String))).toBe(true);
     });
   });
-    
+
   it("should call the native method startUITrace", () => {
     APM.startUITrace("uiTrace");
 
@@ -81,4 +90,10 @@ describe("APM Module", () => {
 
     expect(endUITrace.calledOnceWithExactly()).toBe(true);
   });
+
+  it("should call the native method _ibgSleep", () => {
+    APM._ibgSleep();
+
+    expect(_ibgSleep.calledOnceWithExactly()).toBe(true);
+  });
 });

__tests__/networkLogger.spec.js

@@ -37,6 +37,7 @@ describe('NetworkLogger Module', () => {
     const disableInterception = sinon.spy(Interceptor, 'disableInterception');
     const networkLog = sinon.spy(NativeModules.Instabug, 'networkLog');
     const apmNetworkLog = sinon.spy(NativeModules.IBGAPM, 'networkLog');
+    const apolloLinkRequestHandler = sinon.spy(NetworkLogger, 'apolloLinkRequestHandler')
 
     const network = {
         url: 'https://api.instabug.com',
@@ -58,6 +59,7 @@ describe('NetworkLogger Module', () => {
         IBGEventEmitter.removeAllListeners();
         NetworkLogger.setNetworkDataObfuscationHandler(null);
         apmNetworkLog.resetHistory();
+        apolloLinkRequestHandler.resetHistory();
     });
 
     it('should set onProgressCallback with callback', () => {
@@ -157,5 +159,24 @@ describe('NetworkLogger Module', () => {
         expect(apmNetworkLog.notCalled).toBe(true);
     });
 
+    it('should test that operationSetContext at apollo handler called', async () => {
+      const operation = {
+        setContext : (callback) => callback({ headers : {} }),
+        operationName : "operationName"
+      };
+      const forward = jest.fn();
+      const operationSetContextMock = sinon.spy(operation, 'setContext')
+      
+      NetworkLogger.apolloLinkRequestHandler(operation, forward);
+      expect(operationSetContextMock.calledOnce).toBe(true);
+    });
+  
+    it('should test that apollo handler called with catch error', async () => {
+      const operation = {};
+      const forward = jest.fn();
+  
+      NetworkLogger.apolloLinkRequestHandler(operation, forward);
+      expect(apolloLinkRequestHandler.calledOnce).toBe(true);
+    });
 
 });

__tests__/xhrNetworkInterceptor.spec.js

@@ -45,7 +45,7 @@ describe('Network Interceptor', () => {
 
     it('should set network object on calling setRequestHeader', (done) => {
 
-        let requestHeaders = { 'Content-type': 'application/json', 'token': '9u4hiudhi3bf' };
+        let requestHeaders = { 'content-type': 'application/json', 'token': '9u4hiudhi3bf' };
 
         Interceptor.enableInterception();
         Interceptor.setOnDoneCallback((network) => {
@@ -88,7 +88,7 @@ describe('Network Interceptor', () => {
 
     it('should set responseHeaders in network object on receiving response', (done) => {
 
-        const headers = { 'Content-type': 'application/json', 'Accept': 'text/html' }
+        const headers = { 'Content-type': 'application/json', 'Accept': 'text/html','Content-Length':144 }
         Interceptor.enableInterception();
         Interceptor.setOnDoneCallback((network) => {
             expect(network.responseHeaders['Content-type'].trim()).toEqual(headers['Content-type']);
@@ -173,6 +173,7 @@ describe('Network Interceptor', () => {
       const headers = {};
       headers[InstabugConstants.GRAPHQL_HEADER] =
         InstabugConstants.GRAPHQL_HEADER;
+      const responseBody = { data: [{ item: 'first' }, { item: 'second' }] };
       Interceptor.enableInterception();
       Interceptor.setOnDoneCallback((network) => {
         expect(network.gqlQueryName).toEqual(
@@ -183,6 +184,20 @@ describe('Network Interceptor', () => {
       FakeRequest.open(method, url);
       FakeRequest.setRequestHeaders(headers);
       FakeRequest.send();
+      FakeRequest.mockResponse(requests[0], null, JSON.stringify(responseBody));
+    });
+
+    it('should set gqlQueryName in network object on receiving response with empty string', (done) => {
+      const headers = {};
+      headers[InstabugConstants.GRAPHQL_HEADER] = 'null';
+      Interceptor.enableInterception();
+      Interceptor.setOnDoneCallback((network) => {
+        expect(network.gqlQueryName).toEqual('');
+        done();
+      });
+      FakeRequest.open(method, url);
+      FakeRequest.setRequestHeaders(headers);
+      FakeRequest.send();
       FakeRequest.mockResponse(requests[0]);
     });
 

jest/mockAPM.js

@@ -10,7 +10,11 @@ jest.mock("NativeModules", () => {
       endExecutionTrace: jest.fn(),
       startUITrace: jest.fn(),
       endUITrace: jest.fn(),
+      setNetworkEnabledIOS: jest.fn(),
+      ibgSleep: jest.fn(),
+    },
+    Instabug: {
+      setNetworkLoggingEnabled: jest.fn(),
     },
-    Instabug: {},
   };
 });

modules/NetworkLogger.js

@@ -6,16 +6,6 @@ let { Instabug, IBGAPM } = NativeModules;
 
 var _networkDataObfuscationHandlerSet = false;
 var _requestFilterExpression = false;
-const appendOperationName = (headers, operationName) => {
-  try {
-    let newHeaders = JSON.parse(JSON.stringify(headers));
-    newHeaders[InstabugConstants.GRAPHQL_HEADER] = operationName;
-    return newHeaders;
-  } catch(e) {
-    console.error(e);
-    return headers;
-  }
-};
 
 /**
  * NetworkLogger
@@ -104,10 +94,11 @@ export default {
 
   apolloLinkRequestHandler(operation, forward) {
     try {
-      operation.setContext(({ headers = {} }) => ({
-        headers: appendOperationName(headers, operation.operationName),
-      }));
-    } catch(e) {
+      operation.setContext(({ headers = {} }) => {
+        headers[InstabugConstants.GRAPHQL_HEADER] = operation.operationName;
+        return {headers:headers};
+      });
+    } catch (e) {
       console.error(e);
     }