Skip to content

Commit f238034

Browse files
chore: update CHANGELOG.md, rename setScreenRenderingEnabled api on native SDKs for consistency
1 parent ac727a7 commit f238034

File tree

10 files changed

+23
-17
lines changed

10 files changed

+23
-17
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
- Add support Advanced UI customization. ([#1411](https://github.com/Instabug/Instabug-React-Native/pull/1411))
1212

13+
- Add screen rendering monitoring functionality within the APM product. ([#1416](https://github.com/Instabug/Instabug-React-Native/pull/1416))
14+
1315
## [15.0.2](https://github.com/Instabug/Instabug-React-Native/compare/v15.2.0...dev)
1416

1517
### Added

android/src/main/java/com/instabug/reactlibrary/RNInstabugAPMModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ private void networkLogAndroid(final double requestStartTime,
396396
* @param isEnabled boolean indicating enabled or disabled.
397397
*/
398398
@ReactMethod
399-
public void setScreenRenderEnabled(boolean isEnabled) {
399+
public void setScreenRenderingEnabled(boolean isEnabled) {
400400
MainThreadHandler.runOnMainThread(new Runnable() {
401401
@Override
402402
public void run() {

examples/default/ios/Podfile.lock

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ PODS:
3131
- hermes-engine (0.75.4):
3232
- hermes-engine/Pre-built (= 0.75.4)
3333
- hermes-engine/Pre-built (0.75.4)
34-
- Instabug (15.1.1)
34+
- Instabug (15.1.26)
3535
- instabug-reactnative-ndk (0.1.0):
3636
- DoubleConversion
3737
- glog
@@ -1626,7 +1626,7 @@ PODS:
16261626
- ReactCommon/turbomodule/core
16271627
- Yoga
16281628
- RNInstabug (15.0.2):
1629-
- Instabug (= 15.1.1)
1629+
- Instabug (= 15.1.26)
16301630
- React-Core
16311631
- RNReanimated (3.16.1):
16321632
- DoubleConversion
@@ -1770,6 +1770,7 @@ DEPENDENCIES:
17701770
- fmt (from `../node_modules/react-native/third-party-podspecs/fmt.podspec`)
17711771
- glog (from `../node_modules/react-native/third-party-podspecs/glog.podspec`)
17721772
- hermes-engine (from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`)
1773+
- Instabug (from `https://ios-releases.instabug.com/custom/faeture-screen_rendering-release/15.1.26/Instabug.podspec`)
17731774
- instabug-reactnative-ndk (from `../node_modules/instabug-reactnative-ndk`)
17741775
- OCMock
17751776
- RCT-Folly (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)
@@ -1850,7 +1851,6 @@ SPEC REPOS:
18501851
trunk:
18511852
- Google-Maps-iOS-Utils
18521853
- GoogleMaps
1853-
- Instabug
18541854
- OCMock
18551855
- SocketRocket
18561856

@@ -1868,6 +1868,8 @@ EXTERNAL SOURCES:
18681868
hermes-engine:
18691869
:podspec: "../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec"
18701870
:tag: hermes-2024-08-15-RNv0.75.1-4b3bf912cc0f705b51b71ce1a5b8bd79b93a451b
1871+
Instabug:
1872+
:podspec: https://ios-releases.instabug.com/custom/faeture-screen_rendering-release/15.1.26/Instabug.podspec
18711873
instabug-reactnative-ndk:
18721874
:path: "../node_modules/instabug-reactnative-ndk"
18731875
RCT-Folly:
@@ -2022,7 +2024,7 @@ SPEC CHECKSUMS:
20222024
Google-Maps-iOS-Utils: f77eab4c4326d7e6a277f8e23a0232402731913a
20232025
GoogleMaps: 032f676450ba0779bd8ce16840690915f84e57ac
20242026
hermes-engine: ea92f60f37dba025e293cbe4b4a548fd26b610a0
2025-
Instabug: 3e7af445c14d7823fcdecba223f09b5f7c0c6ce1
2027+
Instabug: c47bd604b5212496da79b19b368eb5de73833d69
20262028
instabug-reactnative-ndk: d765ac289d56e8896398d02760d9abf2562fc641
20272029
OCMock: 589f2c84dacb1f5aaf6e4cec1f292551fe748e74
20282030
RCT-Folly: 4464f4d875961fce86008d45f4ecf6cef6de0740
@@ -2090,14 +2092,14 @@ SPEC CHECKSUMS:
20902092
ReactCommon: 6a952e50c2a4b694731d7682aaa6c79bc156e4ad
20912093
RNCClipboard: 2821ac938ef46f736a8de0c8814845dde2dcbdfb
20922094
RNGestureHandler: 511250b190a284388f9dd0d2e56c1df76f14cfb8
2093-
RNInstabug: c4d26c830b40c474422012d1a216d8ea37c88151
2095+
RNInstabug: 22cc867a673c42a5f293542222efb20fcdf9a352
20942096
RNReanimated: f42a5044d121d68e91680caacb0293f4274228eb
20952097
RNScreens: c7ceced6a8384cb9be5e7a5e88e9e714401fd958
20962098
RNSVG: 8b1a777d54096b8c2a0fd38fc9d5a454332bbb4d
20972099
RNVectorIcons: 6382277afab3c54658e9d555ee0faa7a37827136
20982100
SocketRocket: abac6f5de4d4d62d24e11868d7a2f427e0ef940d
2099-
Yoga: 055f92ad73f8c8600a93f0e25ac0b2344c3b07e6
2101+
Yoga: aa3df615739504eebb91925fc9c58b4922ea9a08
21002102

2101-
PODFILE CHECKSUM: 837b933596e1616ff02cc206bb17dee4f611fdbc
2103+
PODFILE CHECKSUM: 4e2ae668f4fb59c72dfd359d3d9c86ec6d4967e5
21022104

2103-
COCOAPODS: 1.14.0
2105+
COCOAPODS: 1.15.2

examples/default/src/App.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,16 @@ import { StyleSheet } from 'react-native';
33

44
import { GestureHandlerRootView } from 'react-native-gesture-handler';
55
import { NavigationContainer, useNavigationContainerRef } from '@react-navigation/native';
6-
import type { SessionMetadata } from 'instabug-reactnative';
76
import Instabug, {
7+
APM,
88
CrashReporting,
99
InvocationEvent,
1010
LaunchType,
1111
LogLevel,
1212
NetworkInterceptionMode,
1313
NetworkLogger,
1414
ReproStepsMode,
15+
type SessionMetadata,
1516
SessionReplay,
1617
} from 'instabug-reactnative';
1718
import { NativeBaseProvider } from 'native-base';
@@ -60,6 +61,7 @@ export const App: React.FC = () => {
6061

6162
useEffect(() => {
6263
initializeInstabug();
64+
APM.setScreenRenderingEnabled(true);
6365
NetworkLogger.setNetworkDataObfuscationHandler(async (networkData) => {
6466
networkData.url = `${networkData.url}/JS/Obfuscated`;
6567
return networkData;

ios/RNInstabug/InstabugAPMBridge.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
- (void)startUITrace:(NSString *)name;
2222
- (void)endUITrace;
2323

24-
- (void)setScreenRenderEnabled:(BOOL)isEnabled;
24+
- (void)setScreenRenderingEnabled:(BOOL)isEnabled;
2525

2626
extern NSMutableDictionary *traces;
2727

ios/RNInstabug/InstabugAPMBridge.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ - (id) init
9090
}
9191

9292
// Enables or disables screen render.
93-
RCT_EXPORT_METHOD(setScreenRenderEnabled:(BOOL)isEnabled) {
93+
RCT_EXPORT_METHOD(setScreenRenderingEnabled:(BOOL)isEnabled) {
9494
IBGAPM.screenRenderingEnabled = isEnabled;
9595
}
9696

src/modules/APM.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,5 +121,5 @@ export const _ibgSleep = () => {
121121
* @param isEnabled
122122
*/
123123
export const setScreenRenderingEnabled = (isEnabled: boolean) => {
124-
NativeAPM.setScreenRenderEnabled(isEnabled);
124+
NativeAPM.setScreenRenderingEnabled(isEnabled);
125125
};

src/native/NativeAPM.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export interface ApmNativeModule extends NativeModule {
4646
ibgSleep(): void;
4747

4848
// Screen Rendering //
49-
setScreenRenderEnabled(isEnabled: boolean): void;
49+
setScreenRenderingEnabled(isEnabled: boolean): void;
5050
}
5151

5252
export const NativeAPM = NativeModules.IBGAPM;

test/mocks/mockAPM.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const mockAPM: ApmNativeModule = {
1414
endAppLaunch: jest.fn(),
1515
ibgSleep: jest.fn(),
1616
networkLogAndroid: jest.fn(),
17-
setScreenRenderEnabled: jest.fn(),
17+
setScreenRenderingEnabled: jest.fn(),
1818
};
1919

2020
export default mockAPM;

test/modules/APM.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ describe('APM Module', () => {
105105
it('should call the native method setScreenRenderEnabled', () => {
106106
APM.setScreenRenderingEnabled(true);
107107

108-
expect(NativeAPM.setScreenRenderEnabled).toBeCalledTimes(1);
109-
expect(NativeAPM.setScreenRenderEnabled).toBeCalledWith(true);
108+
expect(NativeAPM.setScreenRenderingEnabled).toBeCalledTimes(1);
109+
expect(NativeAPM.setScreenRenderingEnabled).toBeCalledWith(true);
110110
});
111111
});

0 commit comments

Comments
 (0)