Skip to content

Commit 82c47e0

Browse files
committed
Apply review comments
1 parent e8430a9 commit 82c47e0

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

lib/fastlane/plugin/instabug_stores_upload/actions/instabug_build_android_app_action.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def self.run(params)
5454
step: "build_app",
5555
extras: {
5656
build_time:,
57-
build_path:
57+
build_path: Array(build_path)
5858
}
5959
)
6060

lib/fastlane/plugin/instabug_stores_upload/actions/instabug_build_ios_app_action.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def self.run(params)
5454
step: "build_app",
5555
extras: {
5656
build_time:,
57-
build_path:
57+
build_path: Array(build_path)
5858
}
5959
)
6060

lib/fastlane/plugin/instabug_stores_upload/helper/instabug_stores_upload_helper.rb

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,10 @@ def self.filter_instabug_params(params, target_action_class)
4141
filtered_config = {}
4242
params.available_options.each do |option|
4343
key = option.key
44-
unless INSTABUG_KEYS.include?(key)
45-
value = params[key]
46-
filtered_config[key] = value if value
47-
end
44+
filtered_config[key] = params[key] unless INSTABUG_KEYS.include?(key)
4845
end
4946

50-
FastlaneCore::Configuration.create(
51-
target_action_class.available_options,
52-
filtered_config
53-
)
47+
FastlaneCore::Configuration.create(target_action_class.available_options, filtered_config)
5448
end
5549

5650
def self.report_status(branch_name:, api_key:, status:, step:, extras: {}, error_message: nil)

0 commit comments

Comments
 (0)