Improve tests

Author: IonBazan

src/Diff/DiffEntry.php

@@ -231,7 +231,8 @@ public function getProjectUrl()
      */
     private function setUrls(UrlGenerator $generator)
     {
-        $this->projectUrl = $generator->getProjectUrl($this->getPackage());
+        $package = $this->getPackage();
+        $this->projectUrl = $generator->getProjectUrl($package);
 
         $operation = $this->getOperation();
 
@@ -241,9 +242,7 @@ private function setUrls(UrlGenerator $generator)
             return;
         }
 
-        if ($operation instanceof InstallOperation || $operation instanceof UninstallOperation) {
-            $this->compareUrl = $generator->getReleaseUrl($operation->getPackage());
-        }
+        $this->compareUrl = $generator->getReleaseUrl($package);
     }
 
     /**

tests/Diff/DiffEntryTest.php

@@ -57,20 +57,72 @@ public function testGetPackage()
         $this->assertSame($package, $entry->getPackage());
     }
 
+    /**
+     * @param string $expectedUrl
+     *
+     * @dataProvider operationUrlProvider
+     */
+    public function testUrls($expectedUrl, OperationInterface $operation)
+    {
+        $urlGenerator = $this->getMockBuilder('IonBazan\ComposerDiff\Url\UrlGenerator')->getMock();
+        $urlGenerator->method('getCompareUrl')->willReturn('compare');
+        $urlGenerator->method('getProjectUrl')->willReturn('project');
+        $urlGenerator->method('getReleaseUrl')->willReturn('release');
+
+        $entry = new DiffEntry($operation, $urlGenerator);
+        $this->assertSame($expectedUrl, $entry->getUrl());
+        $this->assertSame('project', $entry->getProjectUrl());
+    }
+
     public function testGetUrlReturnsNullForInvalidOperation()
     {
         $operation = $this->getMockBuilder('Composer\DependencyResolver\Operation\OperationInterface')->getMock();
-        $entry = new DiffEntry($operation);
-        $this->assertNull($entry->getUrl());
+        $this->setExpectedException('InvalidArgumentException', 'Invalid operation');
+        new DiffEntry($operation, $this->getMockBuilder('IonBazan\ComposerDiff\Url\UrlGenerator')->getMock());
     }
 
     public function testGetProjectUrlReturnsNullForInvalidOperation()
+    {
+        $operation = $this->getMockBuilder('Composer\DependencyResolver\Operation\OperationInterface')->getMock();
+        $this->setExpectedException('InvalidArgumentException', 'Invalid operation');
+        new DiffEntry($operation, $this->getMockBuilder('IonBazan\ComposerDiff\Url\UrlGenerator')->getMock());
+    }
+
+    public function testCreateWithoutUrlGenerators()
     {
         $operation = $this->getMockBuilder('Composer\DependencyResolver\Operation\OperationInterface')->getMock();
         $entry = new DiffEntry($operation);
+
+        $this->assertNull($entry->getUrl());
         $this->assertNull($entry->getProjectUrl());
     }
 
+    public function operationUrlProvider()
+    {
+        return array(
+            'Install shows release URL' => array(
+                'release',
+                new InstallOperation($this->getPackage('a/package-1', '1.0.0')),
+            ),
+            'Remove shows release URL' => array(
+                'release',
+                new UninstallOperation($this->getPackage('a/package-1', '1.0.0')),
+            ),
+            'Upgrade shows compare URL' => array(
+                'compare',
+                new UpdateOperation($this->getPackage('a/package-1', '1.0.0'), $this->getPackage('a/package-1', '2.0.0')),
+            ),
+            'Downgrade shows compare URL' => array(
+                'compare',
+                new UpdateOperation($this->getPackage('a/package-1', '2.0.0'), $this->getPackage('a/package-1', '1.0.0')),
+            ),
+            'Change shows compare URL' => array(
+                'compare',
+                new UpdateOperation($this->getPackage('a/package-1', 'dev-master', 'dev-master 1234567'), $this->getPackage('a/package-1', '1.0.0')),
+            ),
+        );
+    }
+
     public function operationTypeProvider()
     {
         return array(