Skip to content

Commit 621417e

Browse files
IonBazanIonBazan
committed
refactor
1 parent b88f135 commit 621417e

17 files changed

+166
-99
lines changed

‎src/Command/DiffCommand.php‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,11 @@ protected function handle(InputInterface $input, OutputInterface $output)
147147
$this->gitlabDomains = array_merge($this->gitlabDomains, $input->getOption('gitlab-domains'));
148148

149149
$urlGenerators = new GeneratorContainer($this->gitlabDomains);
150-
$formatters = new FormatterContainer($output, $urlGenerators);
150+
$formatters = new FormatterContainer($output);
151151
$formatter = $formatters->getFormatter($input->getOption('format'));
152152

153+
$this->packageDiff->setUrlGenerator($urlGenerators);
154+
153155
$prodOperations = new DiffEntries(array());
154156
$devOperations = new DiffEntries(array());
155157

‎src/Diff/DiffEntry.php‎

Lines changed: 39 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,25 @@ class DiffEntry
2727
/** @var string */
2828
private $type;
2929

30+
/** @var string|null */
31+
private $compareUrl;
32+
33+
/** @var string|null */
34+
private $projectUrl;
35+
3036
/**
31-
* @param bool $direct
37+
* @param UrlGenerator|null $urlGenerator
38+
* @param bool $direct
3239
*/
33-
public function __construct(OperationInterface $operation, $direct = false)
40+
public function __construct(OperationInterface $operation, $urlGenerator = null, $direct = false)
3441
{
3542
$this->operation = $operation;
3643
$this->direct = $direct;
3744
$this->type = $this->determineType();
45+
46+
if ($urlGenerator instanceof UrlGenerator) {
47+
$this->setUrls($urlGenerator);
48+
}
3849
}
3950

4051
/**
@@ -136,11 +147,11 @@ public function getLicenses()
136147
/**
137148
* @return array<string, string|bool|null|string[]>
138149
*/
139-
public function toArray(UrlGenerator $generator)
150+
public function toArray()
140151
{
141152
$array = $this->toBaseArray();
142-
$array['compare'] = $this->getUrl($generator);
143-
$array['link'] = $this->getProjectUrl($generator);
153+
$array['compare'] = $this->getUrl();
154+
$array['link'] = $this->getProjectUrl();
144155

145156
return $array;
146157
}
@@ -191,30 +202,38 @@ public function toBaseArray()
191202
/**
192203
* @return string|null
193204
*/
194-
public function getUrl(UrlGenerator $generator)
205+
public function getUrl()
195206
{
196-
$operation = $this->getOperation();
197-
198-
if ($operation instanceof UpdateOperation) {
199-
return $generator->getCompareUrl($operation->getInitialPackage(), $operation->getTargetPackage());
200-
}
201-
202-
if ($operation instanceof InstallOperation || $operation instanceof UninstallOperation) {
203-
return $generator->getReleaseUrl($operation->getPackage());
204-
}
207+
return $this->compareUrl;
208+
}
205209

206-
return null;
210+
/**
211+
* @return string|null
212+
*/
213+
public function getProjectUrl()
214+
{
215+
return $this->projectUrl;
207216
}
208217

209-
public function getProjectUrl(UrlGenerator $generator)
218+
private function setUrls(UrlGenerator $generator)
210219
{
211220
$package = $this->getPackage();
212221

213-
if (!isset($package)) {
214-
return null;
222+
if (isset($package)) {
223+
$this->projectUrl = $generator->getProjectUrl($package);
224+
}
225+
226+
$operation = $this->getOperation();
227+
228+
if ($operation instanceof UpdateOperation) {
229+
$this->compareUrl = $generator->getCompareUrl($operation->getInitialPackage(), $operation->getTargetPackage());
230+
231+
return;
215232
}
216233

217-
return $generator->getProjectUrl($package);
234+
if ($operation instanceof InstallOperation || $operation instanceof UninstallOperation) {
235+
$this->compareUrl = $generator->getReleaseUrl($operation->getPackage());
236+
}
218237
}
219238

220239
/**

‎src/Formatter/AbstractFormatter.php‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,9 @@ abstract class AbstractFormatter implements Formatter
1313
*/
1414
protected $output;
1515

16-
/**
17-
* @var GeneratorContainer
18-
*/
19-
protected $generators;
20-
21-
public function __construct(OutputInterface $output, GeneratorContainer $generators)
16+
public function __construct(OutputInterface $output)
2217
{
2318
$this->output = $output;
24-
$this->generators = $generators;
2519
}
2620

2721
/**
@@ -35,7 +29,7 @@ protected function getDecoratedPackageName(DiffEntry $entry)
3529
return '';
3630
}
3731

38-
return $this->terminalLink($entry->getProjectUrl($this->generators), $package->getName());
32+
return $this->terminalLink($entry->getProjectUrl(), $package->getName());
3933
}
4034

4135
/**

‎src/Formatter/FormatterContainer.php‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace IonBazan\ComposerDiff\Formatter;
44

5-
use IonBazan\ComposerDiff\Url\GeneratorContainer;
65
use Symfony\Component\Console\Output\OutputInterface;
76

87
class FormatterContainer
@@ -14,13 +13,13 @@ class FormatterContainer
1413
*/
1514
private $formatters;
1615

17-
public function __construct(OutputInterface $output, GeneratorContainer $generators)
16+
public function __construct(OutputInterface $output)
1817
{
1918
$this->formatters = array(
20-
'mdtable' => new MarkdownTableFormatter($output, $generators),
21-
'mdlist' => new MarkdownListFormatter($output, $generators),
22-
'github' => new GitHubFormatter($output, $generators),
23-
'json' => new JsonFormatter($output, $generators),
19+
'mdtable' => new MarkdownTableFormatter($output),
20+
'mdlist' => new MarkdownListFormatter($output),
21+
'github' => new GitHubFormatter($output),
22+
'json' => new JsonFormatter($output),
2423
);
2524
}
2625

‎src/Formatter/GitHubFormatter.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ private function transformEntries(DiffEntries $entries, $withUrls, $withLicenses
5858
private function transformEntry(DiffEntry $entry, $withUrls, $withLicenses)
5959
{
6060
$operation = $entry->getOperation();
61-
$url = $withUrls ? $entry->getUrl($this->generators) : null;
61+
$url = $withUrls ? $entry->getUrl() : null;
6262
$url = (null !== $url) ? ' '.$url : '';
6363
$licenses = $withLicenses ? implode(', ', $entry->getLicenses()) : '';
6464
$licenses = ('' !== $licenses) ? ' (License: '.$licenses.')' : '';

‎src/Formatter/JsonFormatter.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private function transformEntries(DiffEntries $entries, $withUrls, $withLicenses
4949

5050
/** @var DiffEntry $entry */
5151
foreach ($entries as $entry) {
52-
$row = $entry->toArray($this->generators);
52+
$row = $entry->toArray();
5353

5454
if (!$withUrls) {
5555
unset($row['compare'], $row['link']);

‎src/Formatter/MarkdownListFormatter.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,15 @@ public function renderSingle(DiffEntries $entries, $title, $withUrls, $withLicen
4747
*/
4848
private function getRow(DiffEntry $entry, $withUrls, $withLicenses)
4949
{
50-
$url = $withUrls ? $this->formatUrl($entry->getUrl($this->generators), 'Compare') : null;
50+
$url = $withUrls ? $this->formatUrl($entry->getUrl(), 'Compare') : null;
5151
$url = (null !== $url && '' !== $url) ? ' '.$url : '';
5252
$licenses = $withLicenses ? implode(', ', $entry->getLicenses()) : '';
5353
$licenses = ('' !== $licenses) ? ' (License: '.$licenses.')' : '';
5454
$operation = $entry->getOperation();
5555
$package = $entry->getPackage();
5656

5757
$packageName = $package ? $package->getName() : null;
58-
$packageUrl = $withUrls ? $this->formatUrl($entry->getProjectUrl($this->generators), $packageName) : $packageName;
58+
$packageUrl = $withUrls ? $this->formatUrl($entry->getProjectUrl(), $packageName) : $packageName;
5959

6060
if ($operation instanceof InstallOperation) {
6161
return sprintf(

‎src/Formatter/MarkdownTableFormatter.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function renderSingle(DiffEntries $entries, $title, $withUrls, $withLicen
3535
$row = $this->getTableRow($entry, $withUrls);
3636

3737
if ($withUrls) {
38-
$row[] = $this->formatUrl($entry->getUrl($this->generators), 'Compare');
38+
$row[] = $this->formatUrl($entry->getUrl(), 'Compare');
3939
}
4040

4141
if ($withLicenses) {
@@ -69,7 +69,7 @@ private function getTableRow(DiffEntry $entry, $withUrls)
6969
{
7070
$operation = $entry->getOperation();
7171
$packageName = $this->getDecoratedPackageName($entry);
72-
$packageUrl = $withUrls ? $this->formatUrl($entry->getProjectUrl($this->generators), $packageName) : $packageName;
72+
$packageUrl = $withUrls ? $this->formatUrl($entry->getProjectUrl(), $packageName) : $packageName;
7373

7474
if ($operation instanceof InstallOperation) {
7575
return array(

‎src/PackageDiff.php‎

Lines changed: 34 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace IonBazan\ComposerDiff;
44

55
use Composer\DependencyResolver\Operation\InstallOperation;
6-
use Composer\DependencyResolver\Operation\OperationInterface;
76
use Composer\DependencyResolver\Operation\UninstallOperation;
87
use Composer\DependencyResolver\Operation\UpdateOperation;
98
use Composer\Package\AliasPackage;
@@ -13,6 +12,8 @@
1312
use Composer\Repository\RepositoryInterface;
1413
use IonBazan\ComposerDiff\Diff\DiffEntries;
1514
use IonBazan\ComposerDiff\Diff\DiffEntry;
15+
use IonBazan\ComposerDiff\Url\GeneratorContainer;
16+
use IonBazan\ComposerDiff\Url\UrlGenerator;
1617

1718
class PackageDiff
1819
{
@@ -21,13 +22,44 @@ class PackageDiff
2122
const EXTENSION_JSON = '.json';
2223
const GIT_SEPARATOR = ':';
2324

25+
/** @var UrlGenerator */
26+
protected $urlGenerator;
27+
28+
public function __construct()
29+
{
30+
$this->urlGenerator = new GeneratorContainer();
31+
}
32+
33+
public function setUrlGenerator(UrlGenerator $urlGenerator)
34+
{
35+
$this->urlGenerator = $urlGenerator;
36+
}
37+
2438
/**
2539
* @param string[] $directPackages
2640
* @param bool $onlyDirect
2741
*
2842
* @return DiffEntries
2943
*/
3044
public function getDiff(RepositoryInterface $oldPackages, RepositoryInterface $targetPackages, array $directPackages = array(), $onlyDirect = false)
45+
{
46+
$entries = array();
47+
48+
foreach ($this->getOperations($oldPackages, $targetPackages) as $operation) {
49+
$package = $operation instanceof UpdateOperation ? $operation->getTargetPackage() : $operation->getPackage();
50+
$direct = in_array($package->getName(), $directPackages, true);
51+
52+
if ($onlyDirect && !$direct) {
53+
continue;
54+
}
55+
56+
$entries[] = new DiffEntry($operation, $this->urlGenerator, $direct);
57+
}
58+
59+
return new DiffEntries($entries);
60+
}
61+
62+
public function getOperations(RepositoryInterface $oldPackages, RepositoryInterface $targetPackages)
3163
{
3264
$operations = array();
3365

@@ -65,19 +97,7 @@ public function getDiff(RepositoryInterface $oldPackages, RepositoryInterface $t
6597
}
6698
}
6799

68-
$entries = array_map(function (OperationInterface $operation) use ($directPackages) {
69-
$package = $operation instanceof UpdateOperation ? $operation->getTargetPackage() : $operation->getPackage();
70-
71-
return new DiffEntry($operation, in_array($package->getName(), $directPackages, true));
72-
}, $operations);
73-
74-
if ($onlyDirect) {
75-
$entries = array_values(array_filter($entries, function (DiffEntry $entry) {
76-
return $entry->isDirect();
77-
}));
78-
}
79-
80-
return new DiffEntries($entries);
100+
return $operations;
81101
}
82102

83103
/**

0 commit comments

Comments
 (0)