Skip to content

Commit ac44511

Browse files
authored
Fix vcat method ambiguity issues on Julia 1.8 (#210)
* Fix `vcat` method ambiguity issues on Julia 1.8 * Upper bound DiffTests
1 parent 4a50321 commit ac44511

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Project.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "ReverseDiff"
22
uuid = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
3-
version = "1.14.1"
3+
version = "1.14.2"
44

55
[deps]
66
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
@@ -21,6 +21,7 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
2121
ChainRulesCore = "1"
2222
DiffResults = "1"
2323
DiffRules = "1.4"
24+
DiffTests = "< 0.1.2"
2425
ForwardDiff = "0.10"
2526
FunctionWrappers = "1"
2627
LogExpFunctions = "0.3"

src/derivatives/arrays.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function combinations(xs, n)
3333
end
3434

3535
for f in [:hcat, :vcat]
36-
for i = 0:2, c = combinations([:AbstractVector, :TrackedVector, :AbstractMatrix, :TrackedMatrix, :Number, :TrackedReal], i)
36+
for i = 0:2, c = combinations([:AbstractVector, :Vector, :TrackedVector, :AbstractMatrix, :TrackedMatrix, :Number, :TrackedReal], i)
3737
cnames = map(_ -> gensym(), c)
3838
@eval begin
3939
Base.$f($([:($x::$c) for (x, c) in zip(cnames, c)]...), x::TrackedVector) = track($f, $(cnames...), x)
@@ -46,6 +46,7 @@ for f in [:hcat, :vcat]
4646
:Number,
4747
:AbstractVecOrMat,
4848
:(Union{AbstractVector, Number}),
49+
:Vector,
4950
]
5051
@eval begin
5152
Base.$f($([:($x::$c) for (x, c) in zip(cnames, c)]...), x::TrackedVector, xs::$T...) = track($f, $(cnames...), x, xs...)

0 commit comments

Comments
 (0)