Merge branch 'master' into travis-up

Author: matbesancon

.github/workflows/CompatHelper.yml

@@ -0,0 +1,26 @@
+name: CompatHelper
+
+on:
+  schedule:
+    - cron: '00 * * * *'
+  issues:
+    types: [opened, reopened]
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        julia-version: [1.2.0]
+        julia-arch: [x86]
+        os: [ubuntu-latest]
+    steps:
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: ${{ matrix.julia-version }}
+      - name: Pkg.add("CompatHelper")
+        run: julia -e 'using Pkg; Pkg.add("CompatHelper")'
+      - name: CompatHelper.main()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: julia -e 'using CompatHelper; CompatHelper.main()'

Project.toml

@@ -1,7 +1,7 @@
 name = "SparseDiffTools"
 uuid = "47a9eef4-7e08-11e9-0b38-333d64bd3804"
 authors = ["Pankaj Mishra <[email protected]>", "Chris Rackauckas <[email protected]>"]
-version = "0.10.2"
+version = "0.10.3"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

src/differentiation/compute_jacobian_ad.jl

@@ -66,7 +66,7 @@ end
 
 function forwarddiff_color_jacobian(f,
                 x::AbstractArray{<:Number};
-                dx = similar(x), #if dx is nothing, we will estimate dx at the cost of a function call 
+                dx = copy(x), #if dx is nothing, we will estimate dx at the cost of a function call
                 colorvec = 1:length(x),
                 sparsity = nothing,
                 jac_prototype = nothing)
@@ -87,7 +87,7 @@ function forwarddiff_color_jacobian(f,x::AbstractArray{<:Number},jac_cache::Forw
     maxcolor = maximum(colorvec)
 
     vecx = vec(x)
-    
+
     J = jac_prototype isa Nothing ? (sparsity isa Nothing ? false .* vec(dx) .* vecx' : zeros(eltype(x),size(sparsity))) : zero(jac_prototype)
     nrows,ncols = size(J)
 

test/test_ad.jl

@@ -224,4 +224,5 @@ forwarddiff_color_jacobian!(J,iipf,x,dx=similar(x))
 x = SVector{1}([1.])
 f(x) = x
 J = forwarddiff_color_jacobian(f,x)
-@test J ≈ SMatrix{1,1}([1.])
+@test J isa SArray
+@test J ≈ SMatrix{1,1}([1.])

test/test_integration.jl

@@ -5,6 +5,18 @@ using SparsityDetection
 using LinearAlgebra, SparseArrays, Test
 
 fcalls = 0
+
+function f(x)
+  global fcalls += 1
+  dx = similar(x)
+  for i in 2:length(x)-1
+    dx[i] = x[i-1] - 2x[i] + x[i+1]
+  end
+  dx[1] = -2x[1] + x[2]
+  dx[end] = x[end-1] - 2x[end]
+  dx
+end
+
 function f(dx,x)
   global fcalls += 1
   for i in 2:length(x)-1