Skip to content

Commit 62797c8

Browse files
committed
Mark broken tests broken
1 parent 5d9d350 commit 62797c8

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

test/testsuite/random.jl

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,25 @@
66
end
77
cpu_rng = Random.default_rng()
88

9+
SEEDING_BROKEN = (rng != cpu_rng) && !contains(string(AT), "JLArray")
10+
911
@testset "rand" begin # uniform
10-
for T in eltypes, d in (10, (10,10))
12+
@testset "$d $T" for T in eltypes, d in (10, (10, 10), (1024, 1024))
1113
A = AT{T}(undef, d)
1214
B = copy(A)
1315
rand!(rng, A)
1416
rand!(rng, B)
1517
@test Array(A) != Array(B)
1618

19+
A = AT(rand(T, d))
20+
B = AT(rand(T, d))
21+
1722
Random.seed!(rng)
1823
Random.seed!(rng, 1)
1924
rand!(rng, A)
2025
Random.seed!(rng, 1)
2126
rand!(rng, B)
22-
@test all(Array(A) .== Array(B))
27+
@test Array(A) == Array(B) broken=SEEDING_BROKEN && (prod(d) > length(rng.state))
2328

2429
if rng != cpu_rng
2530
rand!(cpu_rng, A)
@@ -44,19 +49,22 @@
4449
@testset "randn" begin # normally-distributed
4550
# XXX: randn calls sqrt, and Base's sqrt(::Complex) performs
4651
# checked type conversions that throw boxed numbers.
47-
for T in filter(isrealfloattype, eltypes), d in (2, (2, 2), (128, 128))
52+
@testset "$d $T" for T in filter(isrealfloattype, eltypes), d in (2, (2, 2), (1024, 1024))
4853
A = AT{T}(undef, d)
4954
B = copy(A)
5055
randn!(rng, A)
5156
randn!(rng, B)
5257
@test Array(A) != Array(B)
5358

59+
A = AT(rand(T, d))
60+
B = AT(rand(T, d))
61+
5462
Random.seed!(rng)
5563
Random.seed!(rng, 1)
5664
randn!(rng, A)
5765
Random.seed!(rng, 1)
5866
randn!(rng, B)
59-
@test Array(A) Array(B)
67+
@test Array(A) == Array(B) broken=SEEDING_BROKEN && (prod(d) > (2 * length(rng.state)))
6068

6169
if rng != cpu_rng
6270
randn!(cpu_rng, A)

0 commit comments

Comments
 (0)