-
-
Notifications
You must be signed in to change notification settings - Fork 35
type stability of left division #1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1475 +/- ##
==========================================
- Coverage 93.90% 93.90% -0.01%
==========================================
Files 34 34
Lines 15930 15937 +7
==========================================
+ Hits 14959 14965 +6
- Misses 971 972 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I assume that the |
|
Sorry, no, they always copy. I'm just reusing the implementations of |
|
I've also fixed the specialized vector methods, because even though they were not type unstable they were returning an answer of the incorrect type. Luckily this involved less copying, not more. |
|
Good to merge? |
|
If you're asking me, yes, I think so. |
Closes #930