Skip to content

Commit 36516a2

Browse files
authored
fix: incorporate PR feedback
1 parent 6021459 commit 36516a2

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

src/julia/devcontainer-feature.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717
"additionalChannels": {
1818
"type": "string",
1919
"default": "",
20-
"description": "Additional Juliaup channels to install, separated by commas (e.g., 'nightly,1.10')"
20+
"description": "Additional Juliaup channels to install, separated by commas (e.g., 'nightly,1.10')",
21+
"proposals": [
22+
"",
23+
"lts,nightly",
24+
]
2125
}
2226
},
2327
"installsAfter": [

src/julia/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export DEBIAN_FRONTEND=noninteractive
5959
cleanup_apt
6060
check_packages curl ca-certificates
6161

62-
su ${USERNAME} -c "curl -fsSL https://install.julialang.org | sh -s -- --yes --default-channel ${CHANNEL}"
62+
su "${USERNAME}" -c "curl -fsSL https://install.julialang.org | sh -s -- --yes --default-channel ${CHANNEL}"
6363

6464
for channel in "${channels[@]}"; do
6565
# if channel is not empty and not equal to the default channel...

test/julia/scenarios.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@
4848
}
4949
}
5050
}
51-
}
51+
}

0 commit comments

Comments
 (0)