Fix broadcast with Zeros (#344)

* Fix broadcast with Zeros

* LazyArrays v1 in docs

* Update test_broadcasting.jl

Author: dlfivefifty

Project.toml

@@ -1,6 +1,6 @@
 name = "BandedMatrices"
 uuid = "aae01518-5342-5314-be14-df237901396f"
-version = "0.17.18"
+version = "0.17.19"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
@@ -11,9 +11,9 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 
 [compat]
 Aqua = "0.6"
-ArrayLayouts = "0.8.14, 1"
+ArrayLayouts = "1"
 Documenter = "0.27"
-FillArrays = "0.13, 1"
+FillArrays = "1"
 SnoopPrecompile = "1"
 julia = "1.6"
 

docs/Project.toml

@@ -5,4 +5,4 @@ LazyArrays = "5078a376-72f3-5289-bfd5-ec5146d43c02"
 
 [compat]
 Documenter = "0.27"
-LazyArrays = "0.22"
+LazyArrays = "1"

src/generic/broadcast.jl

@@ -1024,7 +1024,7 @@ axpy!(α, A::AbstractBandedMatrix, dest::AbstractMatrix) = banded_axpy!(α, A, d
 
 for op in (:*, :/)
     @eval begin
-        broadcasted(::BandedStyle, ::typeof($op), a::Zeros, b::AbstractArray) = _broadcasted_zeros(a, b)
+        broadcasted(::BandedStyle, ::typeof($op), a::Zeros, b::AbstractArray) = _broadcasted_zeros($op, a, b)
         function broadcasted(::BandedStyle, ::typeof($op), a::AbstractArray{T}, b::Ones{V}) where {T,V}
             Base.Broadcast.combine_axes(a, b) # dimension check
             _copy_oftype(a, promote_op(*, T, V))
@@ -1034,7 +1034,7 @@ end
 
 for op in (:*, :\)
     @eval begin
-        broadcasted(::BandedStyle, ::typeof($op), a::AbstractArray, b::Zeros) = _broadcasted_zeros(a, b)
+        broadcasted(::BandedStyle, ::typeof($op), a::AbstractArray, b::Zeros) = _broadcasted_zeros($op, a, b)
         function broadcasted(::BandedStyle, ::typeof($op), a::Ones{T}, b::AbstractArray{V}) where {T,V}
             Base.Broadcast.combine_axes(a, b) # dimension check
             _copy_oftype(b, promote_op(*, T, V))

test/test_broadcasting.jl

@@ -711,4 +711,11 @@ import BandedMatrices: BandedStyle, BandedRows
         b = BandedMatrix(Zeros(0,4), (-1,2))
         @test a-b == a
     end
+
+    @testset "zeros broadcasting" begin
+        A = brand(5,4,2,1)
+        Z = Zeros(5,4)
+        @test Z .* A ≡ Z
+        @test A .* Z ≡ Z
+    end
 end