Skip to content

feat: deprecate timezone argument in favor of utc_offset #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: features
Choose a base branch
from
Open

feat: deprecate timezone argument in favor of utc_offset #75

wants to merge 1 commit into from

Conversation

@Deuchnord
Copy link
Member

Q A
Bug fix? no
New feature? yes
Related issues Thanks @AmauryCarrade for reporting this
Has BC-break no
License GNU AGPL-v3
  • timezone argument is now named utc_offset and accepts both int and float values

@Deuchnord Deuchnord self-assigned this Jun 1, 2025
@Deuchnord Deuchnord changed the title feat: deprecate timezone argument in favor of utc_offset feat: deprecate timezone argument in favor of utc_offset Jun 1, 2025
@Deuchnord Deuchnord force-pushed the feat/replace-timezone-arg branch from 4bb4bc5 to aa0f270 Compare June 1, 2025 09:03
@Deuchnord Deuchnord marked this pull request as ready for review June 1, 2025 09:06
@coveralls
Copy link

coveralls commented Jun 1, 2025 •
edited
Loading

Coverage Status

coverage: 94.572% (+0.3%) from 94.257%
when pulling 35b4759 on feat/replace-timezone-arg
into 6f73309 on features.

AmauryCarrade
AmauryCarrade reviewed Jun 1, 2025
View reviewed changes
Copy link

@AmauryCarrade AmauryCarrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques petits oublis dans la masse :)

@Deuchnord Deuchnord force-pushed the feat/replace-timezone-arg branch from aa0f270 to 755405e Compare June 1, 2025 09:21
@Deuchnord Deuchnord force-pushed the feat/replace-timezone-arg branch from 755405e to 35b4759 Compare June 1, 2025 09:22
@Deuchnord Deuchnord added this to the v1.1 milestone Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AmauryCarrade AmauryCarrade AmauryCarrade left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Deuchnord Deuchnord

Labels

None yet

Projects

None yet

Milestone

v1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Deuchnord @coveralls @AmauryCarrade