Skip to content

bug: dnsrecord never stops trying to update on conflict #210

@mikenairn

Description

@mikenairn

What

The dnsrecord controller no longer stops trying to update the record in the provider zone when it is trying to update the same generation too often. Look like a regression introduced by #100, at least i can't find the equivalent of this anywhere now https://github.com/Kuadrant/dns-operator/pull/100/files#diff-adacb6a4589c65c2d853c0f59ca02d6b8fb50bb388b41de1d13e99b0d128cfe1L405

if dnsRecord.Status.WriteCounter < WriteCounterLimit {
   dnsRecord.Status.WriteCounter++
   wrtiteCounter.WithLabelValues(dnsRecord.Name, dnsRecord.Namespace).Inc()
   logger.V(1).Info("Changes needed on the same generation of record")
} else {

Refinement thoughts:

  • some back off logic for the verification loop, when it fails repeatedly, verify less frequently.
  • maybe add some sort of date information about when the writes last stopped.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Status

In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions