fix(key): Ensure keys with invalid namespaces throw the correct exception

Also improve nullability checks on key methods.

Author: kezz

key/src/main/java/net/kyori/adventure/key/Key.java

@@ -24,6 +24,7 @@
 package net.kyori.adventure.key;
 
 import java.util.Comparator;
+import java.util.Objects;
 import java.util.OptionalInt;
 import java.util.stream.Stream;
 import net.kyori.examination.Examinable;
@@ -105,6 +106,7 @@ public interface Key extends Comparable<Key>, Examinable, Namespaced, Keyed {
    */
   @SuppressWarnings("PatternValidation") // impossible to validate since the character is variable
   static @NotNull Key key(final @NotNull String string, final char character) {
+    Objects.requireNonNull(string, "string");
     final int index = string.indexOf(character);
     final String namespace = index >= 1 ? string.substring(0, index) : MINECRAFT_NAMESPACE;
     final String value = index >= 0 ? string.substring(index + 1) : string;
@@ -121,7 +123,7 @@ public interface Key extends Comparable<Key>, Examinable, Namespaced, Keyed {
    * @since 4.4.0
    */
   static @NotNull Key key(final @NotNull Namespaced namespaced, @KeyPattern.Value final @NotNull String value) {
-    return key(namespaced.namespace(), value);
+    return key(Objects.requireNonNull(namespaced, "namespaced").namespace(), value);
   }
 
   /**
@@ -185,6 +187,7 @@ static boolean parseableNamespace(final @NotNull String namespace) {
    * @since 4.14.0
    */
   static @NotNull OptionalInt checkNamespace(final @NotNull String namespace) {
+    Objects.requireNonNull(namespace, "namespace");
     for (int i = 0, length = namespace.length(); i < length; i++) {
       if (!allowedInNamespace(namespace.charAt(i))) {
         return OptionalInt.of(i);
@@ -212,6 +215,7 @@ static boolean parseableValue(final @NotNull String value) {
    * @since 4.14.0
    */
   static @NotNull OptionalInt checkValue(final @NotNull String value) {
+    Objects.requireNonNull(value, "value");
     for (int i = 0, length = value.length(); i < length; i++) {
       if (!allowedInValue(value.charAt(i))) {
         return OptionalInt.of(i);

key/src/main/java/net/kyori/adventure/key/KeyImpl.java

@@ -45,18 +45,18 @@ final class KeyImpl implements Key {
   private final String value;
 
   KeyImpl(final @NotNull String namespace, final @NotNull String value) {
-    checkError("namespace", namespace, value, Key.checkNamespace(namespace));
-    checkError("value", namespace, value, Key.checkValue(value));
+    checkError("namespace", namespace, namespace, value, Key.checkNamespace(namespace), NAMESPACE_PATTERN);
+    checkError("value", value, namespace, value, Key.checkValue(value), VALUE_PATTERN);
     this.namespace = requireNonNull(namespace, "namespace");
     this.value = requireNonNull(value, "value");
   }
 
-  private static void checkError(final String name, final String namespace, final String value, final OptionalInt index) {
+  private static void checkError(final String name, final String checkPart, final String namespace, final String value, final OptionalInt index, final String pattern) {
     if (index.isPresent()) {
       final int indexValue = index.getAsInt();
-      final char character = value.charAt(indexValue);
+      final char character = checkPart.charAt(indexValue);
       throw new InvalidKeyException(namespace, value, String.format(
-        "Non [a-z0-9_.-] character in %s of Key[%s] at index %d ('%s', bytes: %s)",
+        "Non " + pattern + " character in %s of Key[%s] at index %d ('%s', bytes: %s)",
         name,
         asString(namespace, value),
         indexValue,

key/src/test/java/net/kyori/adventure/key/KeyTest.java

@@ -124,4 +124,9 @@ void testNulChar() {
   void testParseWithEmptyNamespace() {
     assertEquals(Key.key(Key.MINECRAFT_NAMESPACE, "test"), Key.key(":test"));
   }
+
+  @Test
+  void testKeyWithInvalidCharacter() {
+    assertThrows(InvalidKeyException.class, () -> Key.key("a/b", "a"));
+  }
 }