Refactor unit tests for AppUploaderTest, LambdaTestTaskTest, and TestSuiteUploaderTest to remove unnecessary tests, ensuring better focus on essential functionality.

Author: ritwickrajmakhal

src/test/java/io/github/lambdatest/gradle/AppUploaderTest.java

@@ -54,31 +54,4 @@ void constructor_ShouldValidateRequiredParameters() {
                 .isInstanceOf(IllegalArgumentException.class)
                 .hasMessage("App file must have a .apk extension");
     }
-
-    @Test
-    void uploadAppAsync_ShouldReturnCompletableFuture() {
-        // Given
-        AppUploader appUploader = new AppUploader(TEST_USERNAME, TEST_ACCESS_KEY, validApkPath);
-
-        // When/Then - Verify the uploader is created correctly
-        // We don't call uploadAppAsync() to avoid background thread execution
-        assertThat(appUploader).isNotNull();
-
-        // In a real unit test, we would mock the UploaderUtil to test the async
-        // behavior
-        // without making actual network calls
-    }
-
-    @Test
-    void uploadAppAsync_ShouldHandleInvalidCredentials() {
-        // Given - Test that invalid credentials are handled during construction
-        AppUploader appUploader = new AppUploader("invalid_user", "invalid_key", validApkPath);
-
-        // When/Then - The uploader should be created successfully
-        assertThat(appUploader).isNotNull();
-
-        // The actual upload failure would occur when uploadAppAsync() is called and
-        // executed
-        // but we avoid calling it in unit tests to prevent network calls
-    }
 }

src/test/java/io/github/lambdatest/gradle/LambdaTestTaskTest.java

@@ -20,8 +20,6 @@ class LambdaTestTaskTest {
 
     private static final String TEST_USERNAME = "testuser";
     private static final String TEST_ACCESS_KEY = "test_access_key";
-    private static final String TEST_APP_ID = "lt://APP1234567890";
-    private static final String TEST_SUITE_ID = "lt://APP1234567891";
     private static final List<String> TEST_DEVICES = Arrays.asList("Pixel 6-12", "Galaxy S21-11");
 
     @TempDir File tempDir;
@@ -65,48 +63,4 @@ void task_ShouldBeConfigurable_WithAllProperties() {
         assertThat(task).isNotNull();
         assertThat(task).isInstanceOf(LambdaTestTask.class);
     }
-
-    @Test
-    void runLambdaTest_ShouldCoordinateUploadsAndExecution_WhenFilesProvided() {
-        // Given
-        task.setUsername(TEST_USERNAME);
-        task.setAccessKey(TEST_ACCESS_KEY);
-        task.setAppFilePath(validAppPath);
-        task.setTestSuiteFilePath(validTestPath);
-        task.setDevice(TEST_DEVICES);
-
-        // When/Then - Should coordinate uploads (we don't execute to avoid network
-        // calls)
-        assertThat(task).isNotNull();
-        // In a real unit test, we'd mock the UploaderUtil and TestExecutor to avoid
-        // HTTP calls
-    }
-
-    @Test
-    void runLambdaTest_ShouldSkipUploadsAndExecuteTests_WhenIdsAreSet() {
-        // Given - Use pre-uploaded IDs instead of file paths
-        task.setUsername(TEST_USERNAME);
-        task.setAccessKey(TEST_ACCESS_KEY);
-        task.setAppId(TEST_APP_ID);
-        task.setTestSuiteId(TEST_SUITE_ID);
-        task.setDevice(TEST_DEVICES);
-
-        // When/Then - Should skip uploads and proceed to execution
-        assertThat(task).isNotNull();
-        // In a real unit test, we'd mock the TestExecutor to avoid HTTP calls
-    }
-
-    @Test
-    void runLambdaTest_ShouldHandleConfiguration() {
-        // Given
-        task.setUsername(TEST_USERNAME);
-        task.setAccessKey(TEST_ACCESS_KEY);
-        task.setAppFilePath(validAppPath);
-        task.setTestSuiteFilePath(validTestPath);
-        task.setDevice(TEST_DEVICES);
-
-        // When/Then - Should handle configuration properly
-        assertThat(task).isNotNull();
-        // Configuration validation test - no execution to avoid network calls
-    }
 }

src/test/java/io/github/lambdatest/gradle/TestSuiteUploaderTest.java

@@ -56,33 +56,4 @@ void constructor_ShouldValidateRequiredParameters() {
                 .isInstanceOf(IllegalArgumentException.class)
                 .hasMessage("Test suite file must have a .apk extension");
     }
-
-    @Test
-    void uploadTestSuiteAsync_ShouldReturnCompletableFuture() {
-        // Given
-        TestSuiteUploader uploader =
-                new TestSuiteUploader(TEST_USERNAME, TEST_ACCESS_KEY, validApkPath);
-
-        // When/Then - Verify the uploader is created correctly
-        // We don't call uploadTestSuiteAsync() to avoid background thread execution
-        assertThat(uploader).isNotNull();
-
-        // In a real unit test, we would mock the UploaderUtil to test the async
-        // behavior
-        // without making actual network calls
-    }
-
-    @Test
-    void uploadTestSuiteAsync_ShouldHandleInvalidCredentials() {
-        // Given - Test that invalid credentials are handled during construction
-        TestSuiteUploader uploader =
-                new TestSuiteUploader("invalid_user", "invalid_key", validApkPath);
-
-        // When/Then - The uploader should be created successfully
-        assertThat(uploader).isNotNull();
-
-        // The actual upload failure would occur when uploadTestSuiteAsync() is called
-        // and executed
-        // but we avoid calling it in unit tests to prevent network calls
-    }
 }