Issue #32. Fix an issue with crash after called kan set

Author: Nihisil

project/mahjong/ai/main.py

@@ -21,7 +21,7 @@
 
 
 class MainAI(BaseAI):
-    version = '0.2.5'
+    version = '0.2.7'
 
     agari = None
     shanten = None

project/mahjong/player.py

@@ -209,8 +209,8 @@ def enemy_called_riichi(self):
             self.ai.in_defence = True
 
     def add_called_meld(self, meld: Meld):
-        # we had to remove tile from the hand for the kan set
-        if meld.type == Meld.KAN or meld.type == Meld.CHANKAN and meld.called_tile in self.tiles:
+        # we had to remove tile from the hand for closed kan set
+        if (meld.type == Meld.KAN or meld.type == Meld.CHANKAN) and not meld.opened:
             self.tiles.remove(meld.called_tile)
 
         super().add_called_meld(meld)

project/reproducer.py

@@ -206,10 +206,13 @@ class SocketMock(object):
     Reproduce tenhou <-> bot communication
     """
 
-    def __init__(self, log_path):
+    def __init__(self, log_path, log_content=''):
         self.log_path = log_path
         self.commands = []
-        self.text = self._load_text()
+        if not log_content:
+            self.text = self._load_text()
+        else:
+            self.text = log_content
         self._parse_text()
 
     def connect(self, _):

project/tenhou/tests/__init__.py

@@ -0,0 +1,76 @@
+# -*- coding: utf-8 -*-
+import unittest
+
+from reproducer import TenhouLogReproducer, SocketMock
+from tenhou.client import TenhouClient
+from tenhou.decoder import TenhouDecoder, Meld
+
+
+class TenhouClientTestCase(unittest.TestCase):
+
+    def test_fixed_crash_after_called_kan(self):
+        log = """
+        Get: <HELO uname="Name" auth="20170415-1111111" />
+        Get: <LN/>
+        Get: <GO type="137" lobby="0" gpid=""/> <UN n0="1" n1="2" n2="3" n3="4" dan="11,12,13,11" rate="1500,1500,1500,1500" sx="M,M,M,M"/> <TAIKYOKU oya="3" log="123"/>
+        Get: <INIT seed="6,2,2,5,0,37" ten="203,96,474,207" oya="1" hai="90,83,14,33,132,119,129,117,26,52,121,134,29"/> <U/>
+        Get: <E32/> <V/>
+        Get: <F108/> <W/>
+        Get: <G55/> <T89/>
+        Get: <D52/> <U/>
+        Get: <E109/> <V/>
+        Get: <F124/> <W/>
+        Get: <G92/>
+        Get: <T77/>
+        Get: <D121/> <U/>
+        Get: <E125/> <V/>
+        Get: <f123/> <W/>
+        Get: <G10/> <T38/>
+        Get: <D129/> <U/>
+        Get: <e0/> <V/>
+        Get: <F130/> <W/>
+        Get: <G15/> <T42/>
+        Get: <D14/> <U/>
+        Get: <E64/>
+        Get: <V/>
+        Get: <f115/>
+        Get: <N who="3" m="44075" />
+        Get: <G8/> <T5/>
+        Get: <D5/> <U/>
+        Get: <E70/>
+        Get: <V/>
+        Get: <f80/> <W/>
+        Get: <g111/> <T68/>
+        Get: <D68/> <U/>
+        Get: <E113/> <V/>
+        Get: <F21/> <W/>
+        Get: <G128/> <T78/>
+        Get: <D38/> <U/>
+        Get: <E82/> <V/>
+        Get: <f81/> <W/>
+        Get: <g6/> <T116/>
+        Get: <D42/>
+        Get: <N who="1" m="15915" />
+        Get: <E50/> <V/>
+        Get: <F3/> <W/>
+        Get: <G135 t="1"/>
+        Get: <N who="0" m="51755" />
+        Get: <D77/> <U/>
+        Get: <E103/>
+        Get: <V/>
+        Get: <f76/> <W/>
+        Get: <G118 t="3"/>
+        Get: <N who="0" m="30211" /> <T39/>
+        """
+
+        client = TenhouClient(SocketMock(None, log))
+        with self.assertRaises(KeyboardInterrupt) as context:
+            client.connect()
+            client.authenticate()
+            client.start_game()
+
+        # close all threads
+        client.end_game()
+
+        # end of commands is correct way to end log reproducing
+        self.assertTrue('End of commands' in str(context.exception))