Skip to content

Commit 42d595a

Browse files
Suggested fixes by iCR, OpenRefactory, Inc. (#2938)
* Suggested fixes by iCR, OpenRefactory, Inc. * Apply suggestions from code review Co-authored-by: Benjamin Hackl <[email protected]>
1 parent c82c298 commit 42d595a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

manim/cli/render/commands.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def __repr__(self):
123123
req_info = {}
124124

125125
try:
126-
req_info = requests.get(manim_info_url)
126+
req_info = requests.get(manim_info_url, timeout=10)
127127
req_info.raise_for_status()
128128

129129
stable = req_info.json()["info"]["version"]

manim/mobject/opengl/opengl_mobject.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,16 +168,16 @@ def __repr__(self):
168168
return str(self.name)
169169

170170
def __sub__(self, other):
171-
raise NotImplementedError
171+
return NotImplemented
172172

173173
def __isub__(self, other):
174-
raise NotImplementedError
174+
return NotImplemented
175175

176176
def __add__(self, mobject):
177-
raise NotImplementedError
177+
return NotImplemented
178178

179179
def __iadd__(self, mobject):
180-
raise NotImplementedError
180+
return NotImplemented
181181

182182
@classmethod
183183
def set_default(cls, **kwargs):

0 commit comments

Comments
 (0)