Skip to content

Commit 7913f4c

Browse files
committed
Change coverage config gile to read by using eval
1 parent a2b6e17 commit 7913f4c

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

node/playwright-wrapper/evaluation.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -555,6 +555,7 @@ export async function download(request: Request.DownloadOptions, state: Playwrig
555555
});
556556
};
557557
const downloadStarted = _waitForDownload(page, state, saveAs, downloadTimeout, waitForFinish);
558+
logger.info(`Starting download from ${urlString} to ${saveAs}`);
558559
await page.evaluate(script, urlString);
559560
return await downloadStarted;
560561
}

node/playwright-wrapper/playwright-state.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,12 +1137,19 @@ async function _saveCoverageReport(activeIndexedPage: IndexedPage): Promise<Resp
11371137
} else {
11381138
logger.info('v8 coverage disabled');
11391139
}
1140-
1141-
const mcr = new CoverageReport(options);
1142-
if (configFile) {
1143-
logger.info({ 'Config file: ': configFile });
1144-
await mcr.loadConfig(configFile);
1140+
let mergedOptions: CoverageReportOptions;
1141+
if (fs.existsSync(configFile)) {
1142+
logger.info({ 'Config file exists: ': configFile });
1143+
const configFileModule = await eval('require')(configFile);
1144+
mergedOptions = { ...configFileModule, ...options };
1145+
console.log({ 'Merged options: ': mergedOptions });
1146+
} else {
1147+
console.log({ 'No config file found': configFile });
1148+
mergedOptions = { ...options };
11451149
}
1150+
1151+
const mcr = new CoverageReport(mergedOptions);
1152+
11461153
await mcr.add(allCoverage);
11471154
await mcr.generate();
11481155
let message = 'Coverage stopped and report generated';

0 commit comments

Comments
 (0)