Skip to content

Commit 01361e9

Browse files
committed
Corrected Dockerfile, supervisord configuration and developers edit fragment view name
1 parent a465f58 commit 01361e9

File tree

5 files changed

+31
-9
lines changed

5 files changed

+31
-9
lines changed

Dockerfile

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,26 @@ RUN mvn clean package -DskipTests
1717
# Stage 2: Create an image with RabbitMQ and your Spring Boot application
1818
FROM rabbitmq:management-alpine AS final
1919

20-
# Install necessary runtime packages
21-
RUN apk add --no-cache openjdk22-jdk supervisor \
22-
&& rabbitmq-plugins enable --offline rabbitmq_mqtt \
23-
&& rabbitmq-plugins enable --offline rabbitmq_web_mqtt \
24-
&& addgroup -S runtimeUsers \
25-
&& adduser -S runtimeUser -G runtimeUsers
20+
# Download OpenJDK 22 packages from Alpine Edge (since it isn`t available in latest stable alpine 3.20)
21+
# Check if openjdk22 is already installed, and install if not
22+
RUN if ! java --version 2>/dev/null; then \
23+
echo "Installing OpenJDK 22..."; \
24+
apk add --no-cache curl; \
25+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-22.0.2_p9-r2.apk && \
26+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-jre-22.0.2_p9-r2.apk && \
27+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-jmods-22.0.2_p9-r2.apk && \
28+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-jdk-22.0.2_p9-r2.apk && \
29+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-demos-22.0.2_p9-r2.apk && \
30+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-doc-22.0.2_p9-r2.apk && \
31+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-jre-headless-22.0.2_p9-r2.apk && \
32+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-src-22.0.2_p9-r2.apk && \
33+
curl -O https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/openjdk22-static-libs-22.0.2_p9-r2.apk; \
34+
apk add --allow-untrusted ./*.apk && rm ./*.apk; \
35+
fi; \
36+
apk add --no-cache supervisor \
37+
&& rabbitmq-plugins enable --offline rabbitmq_mqtt \
38+
&& rabbitmq-plugins enable --offline rabbitmq_web_mqtt \
39+
&& addgroup -S runtimeUsers && adduser -S runtimeUser -G runtimeUsers
2640

2741
# Copy the Spring Boot application from the build stage
2842
COPY --from=build /app/target/softwaredevelopmentsimulation-1.4.0.jar /app/software-development-simulation.jar

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
![SonarQube Quality Gate](https://img.shields.io/badge/SonarQube%20Quality%20Gate-Passed-brightgreen)
66
![SonarQube Duplicated Lines](https://img.shields.io/badge/SonarQube%20Duplicated%20Lines-0%25-brightgreen)
77
![SonarQube LOC](https://img.shields.io/badge/SonarQube%20LOC-2000-blue)
8-
![JaCoCo Coverage](https://img.shields.io/badge/JaCoCo%20Coverage-93.5%25-brightgreen)
8+
![JaCoCo Coverage](https://img.shields.io/badge/JaCoCo%20Coverage-93.1%25-brightgreen)
99

1010
**Note:** SonarQube information is based on the last GitHub Action run and is generated locally. As such, there is no direct link available to the SonarQube dashboard.
1111

src/main/java/dev/markodojkic/softwaredevelopmentsimulation/web/DevelopersPageController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public ModelAndView getDevelopersPage(){
4646
})
4747
@GetMapping(value = "/developers/edit")
4848
public ModelAndView getEditingDeveloperForm(@RequestParam("developmentTeamIndex") int developmentTeamIndex, @RequestParam("developerIndex") int developerIndex){
49-
ModelAndView editingDeveloperForm = new ModelAndView("/developersPage::editingDeveloperForm"); //Warning is false positive: View is thymeleaf fragment contained in developersPage.html file
49+
ModelAndView editingDeveloperForm = new ModelAndView("developersPage :: editingDeveloperForm"); //Warning is false positive: View is thymeleaf fragment contained in developersPage.html file
5050

5151
editingDeveloperForm.addObject("developmentTeams", getCurrentDevelopmentTeamsSetup());
5252
editingDeveloperForm.addObject("developmentTeamIndex", developmentTeamIndex);

src/test/java/dev/markodojkic/softwaredevelopmentsimulation/test/DevelopersPageControllerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ void when_getRequestIsSentToDevelopersEditEndpoint_editingDeveloperFormViewIsRet
6868
.param("developmentTeamIndex", "0")
6969
.param("developerIndex", "0"))
7070
.andExpect(status().isOk())
71-
.andExpect(view().name("/developersPage::editingDeveloperForm"))
71+
.andExpect(view().name("developersPage :: editingDeveloperForm"))
7272
.andExpect(model().attributeExists("developmentTeams"))
7373
.andExpect(model().attributeExists("developerTypes"))
7474
.andExpect(model().attributeExists("formEditDeveloperPlaceholder"))

supervisord.conf

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
11
[supervisord]
22
nodaemon=true
3+
logfile = /tmp/supervisord.log
4+
pidfile = /tmp/supervisord.pid
35

46
[program:rabbitmq]
57
command=rabbitmq-server
68
autorestart=true
9+
stdout_logfile=/tmp/rabbitmq.log
10+
stderr_logfile=/tmp/rabbitmq.err.log
11+
loglevel = error
712

813
[program:app]
914
command=sh -c "until nc -z localhost 5672; do echo 'Waiting for RabbitMQ...'; sleep 1; done; java -jar /app/software-development-simulation.jar"
1015
autorestart=true
16+
stdout_logfile=/tmp/app.log
17+
stderr_logfile=/tmp/app.err.log
18+
loglevel = error

0 commit comments

Comments
 (0)