Skip to content
This repository was archived by the owner on Sep 23, 2023. It is now read-only.

Commit 57a76cf

Browse files
MatmaRexedg2s
authored andcommitted
Add 'title' to other links with ellipsed text in the wikis table
Also remove unneeded ENT_QUOTES.
1 parent 3aa85d4 commit 57a76cf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

index.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@
243243
$t = $t . ': ' . $commitData[ 'subject' ];
244244
get_linked_tasks( $commitData[ 'message' ], $linkedTaskList );
245245
}
246-
return '<a href="https://gerrit.wikimedia.org/r/c/' . $r . '/' . $p . '" title="' . htmlspecialchars( $t, ENT_QUOTES ) . '" class="status-' . $status . '">' .
246+
return '<a href="https://gerrit.wikimedia.org/r/c/' . $r . '/' . $p . '" title="' . htmlspecialchars( $t ) . '" class="status-' . $status . '">' .
247247
htmlspecialchars( $t ) .
248248
'</a>';
249249
}, $matches[ 1 ], $matches[ 2 ], $matches[ 0 ] ) );
@@ -256,7 +256,7 @@
256256
'task_id' => $task
257257
] )->getResult()['title'] );
258258
}
259-
$taskDesc = '<a href="https://phabricator.wikimedia.org/T' . $task . '">' . $taskDesc . '</a>';
259+
$taskDesc = '<a href="https://phabricator.wikimedia.org/T' . $task . '" title="' . $taskDesc . '">' . $taskDesc . '</a>';
260260
$taskDescs[] = $taskDesc;
261261
}
262262
$linkedTasks = implode( '<br>', $taskDescs );
@@ -320,7 +320,7 @@ function all_closed( $statuses ) {
320320
}
321321

322322
$rows .= '<tr class="' . implode( ' ', $classes ) . '">' .
323-
'<td data-label="Wiki" class="wiki"><a href="wikis/' . $wiki . '/w">' . $wiki . '</a></td>' .
323+
'<td data-label="Wiki" class="wiki"><a href="wikis/' . $wiki . '/w" title="' . $wiki . '">' . $wiki . '</a></td>' .
324324
'<td data-label="Patches" class="patches">' . ( $title ?: '<em>No patches</em>' ) . '</td>' .
325325
'<td data-label="Linked tasks" class="linkedTasks">' . ( $linkedTasks ?: '<em>No tasks</em>' ) . '</td>' .
326326
'<td data-label="Time" class="date">' . date( 'c', $data[ 'mtime' ] ) . '</td>' .

0 commit comments

Comments
 (0)