chore: changed vaultName:. to vaultName in tests

Author: aryanjassal

src/utils/options.ts

@@ -5,7 +5,7 @@
  * but not the default value
  * @module
  */
-import commander, { InvalidArgumentError } from 'commander';
+import commander from 'commander';
 import config from 'polykey/dist/config';
 import * as binParsers from '../utils/parsers';
 
@@ -216,7 +216,7 @@ const envVariables = new commander.Option('-e --env <envs...>', 'specify envs')
       const acc = previous ?? [];
       const [vault, secret, val] = binParsers.parseSecretPathEnv(value);
       if (secret == null) {
-        throw new InvalidArgumentError(
+        throw new commander.InvalidArgumentError(
           'You must provide at least one secret path',
         );
       }

tests/secrets/env.test.ts

@@ -325,7 +325,7 @@ describe('commandEnv', () => {
       dataDir,
       '--env-format',
       'unix',
-      `${vaultName}:.`,
+      `${vaultName}`,
     ];
 
     const result = await testUtils.pkExec([...command], {
@@ -364,8 +364,8 @@ describe('commandEnv', () => {
       dataDir,
       '--env-format',
       'unix',
-      `${vaultName}1:.`,
-      `${vaultName}2:.`,
+      `${vaultName}1`,
+      `${vaultName}2`,
     ];
 
     const result = await testUtils.pkExec([...command], {
@@ -404,8 +404,8 @@ describe('commandEnv', () => {
       dataDir,
       '--env-format',
       'cmd',
-      `${vaultName}1:.`,
-      `${vaultName}2:.`,
+      `${vaultName}1`,
+      `${vaultName}2`,
     ];
 
     const result = await testUtils.pkExec([...command], {
@@ -444,8 +444,8 @@ describe('commandEnv', () => {
       dataDir,
       '--env-format',
       'powershell',
-      `${vaultName}1:.`,
-      `${vaultName}2:.`,
+      `${vaultName}1`,
+      `${vaultName}2`,
     ];
 
     const result = await testUtils.pkExec([...command], {
@@ -475,7 +475,7 @@ describe('commandEnv', () => {
       dataDir,
       '--env-format',
       'json',
-      `${vaultName}:.`,
+      `${vaultName}`,
     ];
 
     const result = await testUtils.pkExec([...command], {
@@ -560,7 +560,7 @@ describe('commandEnv', () => {
         'unix',
         '-ei',
         'error',
-        `${vaultName}:.`,
+        `${vaultName}`,
       ],
       { env: { PK_PASSWORD: password } },
     );
@@ -584,7 +584,7 @@ describe('commandEnv', () => {
         'unix',
         '-ei',
         'warn',
-        `${vaultName}:.`,
+        `${vaultName}`,
       ],
       { env: { PK_PASSWORD: password } },
     );
@@ -612,7 +612,7 @@ describe('commandEnv', () => {
         'unix',
         '-ei',
         'ignore',
-        `${vaultName}:.`,
+        `${vaultName}`,
       ],
       { env: { PK_PASSWORD: password } },
     );
@@ -642,7 +642,7 @@ describe('commandEnv', () => {
         'unix',
         '-ed',
         'error',
-        `${vaultName}:.`,
+        `${vaultName}`,
       ],
       { env: { PK_PASSWORD: password } },
     );
@@ -669,7 +669,7 @@ describe('commandEnv', () => {
         'unix',
         '-ed',
         'warn',
-        `${vaultName}:.`,
+        `${vaultName}`,
       ],
       { env: { PK_PASSWORD: password } },
     );
@@ -698,7 +698,7 @@ describe('commandEnv', () => {
         'unix',
         '-ed',
         'keep',
-        `${vaultName}:.`,
+        `${vaultName}`,
       ],
       { env: { PK_PASSWORD: password } },
     );
@@ -725,7 +725,7 @@ describe('commandEnv', () => {
         'unix',
         '-ed',
         'overwrite',
-        `${vaultName}:.`,
+        `${vaultName}`,
       ],
       { env: { PK_PASSWORD: password } },
     );
@@ -816,4 +816,44 @@ describe('commandEnv', () => {
     });
     expect(result1.exitCode).toBe(64);
   });
+  test('should output all secrets without explicit secret path', async () => {
+    const vaultId1 = await polykeyAgent.vaultManager.createVault(
+      `${vaultName}1`,
+    );
+    const vaultId2 = await polykeyAgent.vaultManager.createVault(
+      `${vaultName}2`,
+    );
+
+    await polykeyAgent.vaultManager.withVaults(
+      [vaultId1, vaultId2],
+      async (vault1, vault2) => {
+        await vaultOps.addSecret(vault1, 'SECRET1', 'this is the secret1');
+        await vaultOps.addSecret(vault2, 'SECRET2', 'this is the secret2');
+        await vaultOps.mkdir(vault1, 'dir1');
+        await vaultOps.mkdir(vault2, 'dir1');
+        await vaultOps.addSecret(vault1, 'dir1/SECRET3', 'this is the secret3');
+        await vaultOps.addSecret(vault2, 'dir1/SECRET4', 'this is the secret4');
+      },
+    );
+
+    command = [
+      'secrets',
+      'env',
+      '-np',
+      dataDir,
+      '--env-format',
+      'unix',
+      `${vaultName}1`,
+      `${vaultName}2`,
+    ];
+
+    const result = await testUtils.pkExec([...command], {
+      env: { PK_PASSWORD: password },
+    });
+    expect(result.exitCode).toBe(0);
+    expect(result.stdout).toContain("SECRET1='this is the secret1'");
+    expect(result.stdout).toContain("SECRET2='this is the secret2'");
+    expect(result.stdout).toContain("SECRET3='this is the secret3'");
+    expect(result.stdout).toContain("SECRET4='this is the secret4'");
+  });
 });