test(agents): Provide basic test coverage

Author: grypez

packages/agents/src/llm.test.ts

@@ -3,15 +3,28 @@ import { consoleTransport, Logger } from '@metamask/logger';
 import { kunser } from '@metamask/ocap-kernel';
 import type { Kernel } from '@metamask/ocap-kernel';
 import { makeKernel } from '@ocap/nodejs';
-import { expect, describe, it, beforeEach } from 'vitest';
+import { expect, describe, it, beforeEach, vi } from 'vitest';
 
+import { makeLlm } from './llm.ts';
 import { getBundleSpec } from './vats/index.ts';
 
 const logger = new Logger({
   tags: ['test'],
   transports: [consoleTransport],
 });
 
+const mocks = vi.hoisted(() => ({
+  Ollama: vi.fn(() => ({
+    generate: vi.fn().mockResolvedValue({
+      [Symbol.asyncIterator]: vi.fn(),
+    }),
+    chat: vi.fn().mockResolvedValue({
+      [Symbol.asyncIterator]: vi.fn(),
+    }),
+  })),
+  makeFarGenerator: vi.fn(),
+}));
+
 describe('llm', () => {
   let kernel: Kernel;
   beforeEach(async () => {
@@ -23,6 +36,41 @@ describe('llm', () => {
     });
   });
 
+  vi.mock('ollama/browser', () => ({
+    Ollama: mocks.Ollama,
+  }));
+
+  vi.mock('@metamask/streams/vat', () => ({
+    makeFarGenerator: mocks.makeFarGenerator,
+  }));
+
+  describe('makeLlm', () => {
+    it('should return an object with generate and chat methods', async () => {
+      const llm = await makeLlm();
+      expect(llm).toHaveProperty('generate');
+      expect(llm).toHaveProperty('chat');
+    });
+
+    it('should pass config to Ollama', async () => {
+      const config = { host: 'http://test' };
+      await makeLlm(config);
+      // check that the Ollama constructor was called with the correct config
+      expect(mocks.Ollama).toHaveBeenCalledOnce();
+      expect(mocks.Ollama.mock.calls?.[0]).toMatchObject([config]);
+    });
+
+    it.each(['generate', 'chat'])(
+      'should promise a FarGenerator from its %s method',
+      async (method) => {
+        const llm = await makeLlm();
+        // @ts-expect-error The underlying ollama library is mocked in these tests
+        const result = await llm[method as keyof typeof llm]();
+        expect(mocks.makeFarGenerator).toHaveBeenCalledOnce();
+        expect(mocks.makeFarGenerator.mock.calls?.[0]).toMatchObject([result]);
+      },
+    );
+  });
+
   // Only run in development mode
   // eslint-disable-next-line n/no-process-env
   describe.runIf(process.env.NODE_ENV === 'development')('integration', () => {

packages/agents/src/vats/index.test.ts

@@ -0,0 +1,15 @@
+import { describe, it, expect } from 'vitest';
+
+import { getBundleSpec } from './index.ts';
+
+describe('getBundleSpec', () => {
+  it.each(['ollama', 'user'])(
+    'should return a valid bundle spec for %s',
+    (bundleName) => {
+      const bundleSpec = getBundleSpec(bundleName);
+      expect(typeof bundleSpec).toBe('string');
+      expect(bundleSpec).toMatch(/^file:\/\//u);
+      expect(bundleSpec).toMatch(new RegExp(`${bundleName}\\.bundle$`, 'u'));
+    },
+  );
+});

packages/agents/src/vats/index.ts

@@ -4,12 +4,5 @@
  * @param bundleName - The name of the bundle.
  * @returns The bundle spec.
  */
-export const getBundleSpec = (bundleName: string): string => {
-  try {
-    return `file://${new URL(`./${bundleName}.bundle`, import.meta.url).pathname}`;
-  } catch (error) {
-    throw new Error(
-      `Failed to getBundleSpec for ${bundleName}: ${error instanceof Error ? error.message : 'Unknown error'}`,
-    );
-  }
-};
+export const getBundleSpec = (bundleName: string): string =>
+  `file://${new URL(`./${bundleName}.bundle`, import.meta.url).pathname}`;