From b2781672bb0da826b8eb53ad51abfea01c1a44e5 Mon Sep 17 00:00:00 2001
From: RealMuffinTime <realmuffintime@gmail.com>
Date: Tue, 21 May 2024 20:56:49 +0200
Subject: [PATCH 1/7] remove hardcoded time placeholder

---
 .../meteorclient/utils/misc/MeteorStarscript.java                | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/java/meteordevelopment/meteorclient/utils/misc/MeteorStarscript.java b/src/main/java/meteordevelopment/meteorclient/utils/misc/MeteorStarscript.java
index ecb8802c57..d177c69649 100644
--- a/src/main/java/meteordevelopment/meteorclient/utils/misc/MeteorStarscript.java
+++ b/src/main/java/meteordevelopment/meteorclient/utils/misc/MeteorStarscript.java
@@ -81,7 +81,6 @@ public static void init() {
         ss.set("mc_version", SharedConstants.getGameVersion().getName());
         ss.set("fps", () -> Value.number(MinecraftClientAccessor.getFps()));
         ss.set("ping", MeteorStarscript::ping);
-        ss.set("time", () -> Value.string(LocalTime.now().format(DateTimeFormatter.ofLocalizedTime(FormatStyle.SHORT))));
         ss.set("cps", () -> Value.number(CPSUtils.getCpsAverage()));
 
         // Meteor

From 3962ca9d765c1657cc06055180ec320525e358eb Mon Sep 17 00:00:00 2001
From: RealMuffinTime <realmuffintime@gmail.com>
Date: Tue, 21 May 2024 22:06:21 +0200
Subject: [PATCH 2/7] rewrite AutoSign, add many features

---
 .../systems/modules/world/AutoSign.java       | 269 ++++++++++++++++--
 1 file changed, 252 insertions(+), 17 deletions(-)

diff --git a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
index 169c168d58..24321fc507 100644
--- a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
+++ b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
@@ -6,42 +6,277 @@
 package meteordevelopment.meteorclient.systems.modules.world;
 
 import meteordevelopment.meteorclient.events.game.OpenScreenEvent;
-import meteordevelopment.meteorclient.events.packets.PacketEvent;
+import meteordevelopment.meteorclient.gui.GuiTheme;
+import meteordevelopment.meteorclient.gui.widgets.containers.WHorizontalList;
 import meteordevelopment.meteorclient.mixin.AbstractSignEditScreenAccessor;
+import meteordevelopment.meteorclient.settings.*;
 import meteordevelopment.meteorclient.systems.modules.Categories;
 import meteordevelopment.meteorclient.systems.modules.Module;
 import meteordevelopment.orbit.EventHandler;
+import meteordevelopment.starscript.StandardLib;
 import net.minecraft.block.entity.SignBlockEntity;
 import net.minecraft.client.gui.screen.ingame.AbstractSignEditScreen;
-import net.minecraft.network.packet.c2s.play.UpdateSignC2SPacket;
+import net.minecraft.network.packet.c2s.play.*;
+import meteordevelopment.meteorclient.gui.utils.StarscriptTextBoxRenderer;
+import meteordevelopment.meteorclient.utils.misc.MeteorStarscript;
+import meteordevelopment.starscript.Script;
+import meteordevelopment.meteorclient.gui.widgets.WWidget;
+import meteordevelopment.meteorclient.gui.widgets.pressable.WButton;
+import net.minecraft.text.Text;
+import net.minecraft.util.Hand;
+import net.minecraft.util.Util;
+import net.minecraft.util.hit.BlockHitResult;
+import java.util.*;
 
 public class AutoSign extends Module {
-    private String[] text;
 
-    public AutoSign() {
-        super(Categories.World, "auto-sign", "Automatically writes signs. The first sign's text will be used.");
-    }
+    private boolean applyingBack = false;
+
+    private final SettingGroup front = settings.createGroup("Front");
+    private final SettingGroup back = settings.createGroup("Back");
+    private final SettingGroup other = settings.createGroup("Other");
+
+    private final List<Script> frontScripts = new ArrayList<>();
+    private final List<Script> backScripts = new ArrayList<>();
+
+    // 4 lines at front of sign
+    public final Setting<Boolean> frontEnabled = front.add(new BoolSetting.Builder()
+        .name("front-enabled")
+        .description("Enable auto writing front of sign.")
+        .defaultValue(true)
+        .build()
+    );
+
+    private final Setting<String> line1front = front.add(new StringSetting.Builder()
+        .name("front-line-1")
+        .description("Text in first line.")
+        .defaultValue("{player}")
+        .onChanged(strings -> recompile(front, frontScripts, 1))
+        .renderer(StarscriptTextBoxRenderer.class)
+        .visible(frontEnabled::get)
+        .build()
+    );
+
+    private final Setting<String> line2front = front.add(new StringSetting.Builder()
+        .name("front-line-2")
+        .description("Text in second line.")
+        .defaultValue("was here")
+        .onChanged(strings -> recompile(front, frontScripts, 2))
+        .renderer(StarscriptTextBoxRenderer.class)
+        .visible(frontEnabled::get)
+        .build()
+    );
+
+    private final Setting<String> line3front = front.add(new StringSetting.Builder()
+        .name("front-line-3")
+        .description("Text in third line.")
+        .defaultValue("{date}")
+        .onChanged(strings -> recompile(front, frontScripts, 3))
+        .renderer(StarscriptTextBoxRenderer.class)
+        .visible(frontEnabled::get)
+        .build()
+    );
+
+    private final Setting<String> line4front = front.add(new StringSetting.Builder()
+        .name("front-line-4")
+        .description("Text in fourth line.")
+        .defaultValue("{time}")
+        .onChanged(strings -> recompile(front, frontScripts, 4))
+        .renderer(StarscriptTextBoxRenderer.class)
+        .visible(frontEnabled::get)
+        .build()
+    );
+
+    // 4 lines at back of sign
+    public final Setting<Boolean> backEnabled = back.add(new BoolSetting.Builder()
+        .name("back-enabled")
+        .description("Enable auto writing back of sign.")
+        .defaultValue(true)
+        .build()
+    );
+
+    private final Setting<String> line1back = back.add(new StringSetting.Builder()
+        .name("back-line-1")
+        .description("Text in first line.")
+        .onChanged(strings -> recompile(back, backScripts, 1))
+        .renderer(StarscriptTextBoxRenderer.class)
+        .visible(backEnabled::get)
+        .build()
+    );
+
+    // It's MuffinTime.
+    private final Setting<String> line2back = back.add(new StringSetting.Builder()
+        .name("back-line-2")
+        .description("Text in second line.")
+        .defaultValue("It's MeteorTime.")
+        .onChanged(strings -> recompile(back, backScripts, 2))
+        .renderer(StarscriptTextBoxRenderer.class)
+        .visible(backEnabled::get)
+        .build()
+    );
+
+    private final Setting<String> line3back = back.add(new StringSetting.Builder()
+        .name("back-line-3")
+        .description("Text in third line.")
+        .onChanged(strings -> recompile(back, backScripts, 3))
+        .renderer(StarscriptTextBoxRenderer.class)
+        .visible(backEnabled::get)
+        .build()
+    );
+
+    private final Setting<String> line4back = back.add(new StringSetting.Builder()
+        .name("back-line-4")
+        .description("Text in fourth line.")
+        .onChanged(strings -> recompile(back, backScripts, 4))
+        .renderer(StarscriptTextBoxRenderer.class)
+        .visible(backEnabled::get)
+        .build()
+    );
+
+    // Other settings
+    public final Setting<Boolean> overwrite = other.add(new BoolSetting.Builder()
+        .name("overwrite-existing")
+        .description("Overwrite existing text on signs, when possible.")
+        .defaultValue(false)
+        .build());
+
+    private final Setting<String> date = other.add(new StringSetting.Builder()
+        .name("date-format")
+        .description("Format string for {date} object.")
+        .defaultValue("yyyy-MM-dd")
+        .build()
+    );
+
+    private final Setting<String> time = other.add(new StringSetting.Builder()
+        .name("time-format")
+        .description("Format string for {time} object.")
+        .defaultValue("HH:mm z")
+        .build()
+    );
+
+    private final Setting<Boolean> utcTimezone = other.add(new BoolSetting.Builder()
+        .name("UTC-timezone")
+        .description("Whether to use UTC or your local timezone.")
+        .defaultValue(true)
+        .build()
+    );
 
     @Override
-    public void onDeactivate() {
-        text = null;
-    }
+    public WWidget getWidget(GuiTheme theme) {
+        WHorizontalList list = theme.horizontalList();
 
-    @EventHandler
-    private void onSendPacket(PacketEvent.Send event) {
-        if (!(event.packet instanceof UpdateSignC2SPacket)) return;
+        WButton starscriptDoc = theme.button("Open Starscript documentation.");
+        starscriptDoc.action = () -> Util.getOperatingSystem().open("https://github.com/MeteorDevelopment/meteor-client/wiki/Starscript");
+        list.add(starscriptDoc);
+
+        WButton simpleDateFormatDoc = theme.button("Open SimpleDateFormat documentation.");
+        simpleDateFormatDoc.action = () -> Util.getOperatingSystem().open("https://docs.oracle.com/javase/8/docs/api/java/text/SimpleDateFormat.html");
+        list.add(simpleDateFormatDoc);
 
-        text = ((UpdateSignC2SPacket) event.packet).getText();
+        return list;
+    }
+
+    public AutoSign() {
+        super(Categories.World, "auto-sign", "Automatically writes signs. Configure what to write dynamically using Starscript placeholders.");
     }
 
     @EventHandler
-    private void onOpenScreen(OpenScreenEvent event) {
-        if (!(event.screen instanceof AbstractSignEditScreen) || text == null) return;
+    private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
+        if (!(event.screen instanceof AbstractSignEditScreen)) return;
+        if (applyingBack) {
+            applyingBack = false;
+            event.cancel();
+            return;
+        }
 
+        // apply custom format and timezone, not the nicest (temporary overwriting global date and time format)
+        try {
+            StandardLib.dateFormat.applyPattern(date.get());
+            StandardLib.timeFormat.applyPattern(time.get());
+        } catch (IllegalArgumentException e) {
+            error(e.getMessage());
+        }
+        if (utcTimezone.get()) {
+            StandardLib.dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
+            StandardLib.timeFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
+        }
+
+        boolean updated = false;
         SignBlockEntity sign = ((AbstractSignEditScreenAccessor) event.screen).getSign();
 
-        mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), true, text[0], text[1], text[2], text[3]));
+        if (frontEnabled.get()) {
+            boolean written = false;
+            for (Text text : sign.getFrontText().getMessages(false))
+                if (!Objects.equals(text.getString(), "") && !written)
+                    written = true;
+            if (overwrite.get() || !written) {
+                mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), true,
+                    frontScripts.get(0) != null ? MeteorStarscript.run(frontScripts.get(0)) : "error",
+                    frontScripts.get(1) != null ? MeteorStarscript.run(frontScripts.get(1)) : "error",
+                    frontScripts.get(2) != null ? MeteorStarscript.run(frontScripts.get(2)) : "error",
+                    frontScripts.get(3) != null ? MeteorStarscript.run(frontScripts.get(3)) : "error"));
+                updated = true;
+            }
+        }
+
+        // Start a second sign interaction (if applicable) to apply second side of sign
+        if (updated && backEnabled.get()) {
+            applyingBack = true;
+
+            // If sign was placed with offhand
+            boolean offhand_swapped = false;
+            if (!mc.player.getMainHandStack().getTranslationKey().endsWith("sign") && !mc.player.getMainHandStack().getTranslationKey().endsWith("air")) {
+                mc.player.networkHandler.sendPacket(new PlayerActionC2SPacket(PlayerActionC2SPacket.Action.SWAP_ITEM_WITH_OFFHAND, mc.player.getBlockPos(), mc.player.getFacing()));
+                offhand_swapped = true;
+            }
+
+            boolean wasSneaking = mc.player.isSneaking();
+            if (wasSneaking) mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY));
+
+            BlockHitResult bhr = new BlockHitResult(sign.getPos().toCenterPos(), mc.player.getFacing().getOpposite(), sign.getPos(), false);
+            mc.player.networkHandler.sendPacket(new PlayerInteractBlockC2SPacket(Hand.MAIN_HAND, bhr, 0));
+
+            if (wasSneaking) mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY));
+
+            if (offhand_swapped) mc.player.networkHandler.sendPacket(new PlayerActionC2SPacket(PlayerActionC2SPacket.Action.SWAP_ITEM_WITH_OFFHAND, mc.player.getBlockPos(), mc.player.getFacing()));
+        }
+
+        if (backEnabled.get()) {
+            boolean written = false;
+            for (Text text : sign.getBackText().getMessages(false))
+                if (!Objects.equals(text.getString(), "") && !written)
+                    written = true;
+            if (overwrite.get() || !written) {
+                mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), false,
+                    backScripts.get(0) != null ? MeteorStarscript.run(backScripts.get(0)) : "error",
+                    backScripts.get(1) != null ? MeteorStarscript.run(backScripts.get(1)) : "error",
+                    backScripts.get(2) != null ? MeteorStarscript.run(backScripts.get(2)) : "error",
+                    backScripts.get(3) != null ? MeteorStarscript.run(backScripts.get(3)) : "error"));
+                updated = true;
+            }
+        }
+
+        // reset formating and timezones
+        StandardLib.dateFormat.applyPattern("dd. MM. yyyy");
+        StandardLib.timeFormat.applyPattern("HH:mm");
+        if (utcTimezone.get()) {
+            StandardLib.dateFormat.setTimeZone(TimeZone.getDefault());
+            StandardLib.timeFormat.setTimeZone(TimeZone.getDefault());
+        }
+
+        // When no sign side was updated open gui normally
+        if (updated)
+            event.cancel();
+    }
+
+    private void recompile(SettingGroup side, List<Script> sideScripts, int line) {
+        String compileLine = (String) side.getByIndex(line).get();
+
+        Script script = MeteorStarscript.compile(compileLine);
 
-        event.cancel();
+        if (sideScripts.size() <= line - 1)
+            sideScripts.add(script);
+        else
+            sideScripts.set(line - 1, script);
     }
 }

From d70b6e4c0a17566323eb7bf779fc527c2f64fbfb Mon Sep 17 00:00:00 2001
From: RealMuffinTime <realmuffintime@gmail.com>
Date: Tue, 21 May 2024 23:23:35 +0200
Subject: [PATCH 3/7] code style :)

---
 .../systems/modules/world/AutoSign.java       | 48 ++++++++++++-------
 1 file changed, 32 insertions(+), 16 deletions(-)

diff --git a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
index 24321fc507..eba8d2eb64 100644
--- a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
+++ b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
@@ -8,25 +8,31 @@
 import meteordevelopment.meteorclient.events.game.OpenScreenEvent;
 import meteordevelopment.meteorclient.gui.GuiTheme;
 import meteordevelopment.meteorclient.gui.widgets.containers.WHorizontalList;
+import meteordevelopment.meteorclient.gui.widgets.pressable.WButton;
+import meteordevelopment.meteorclient.gui.widgets.WWidget;
+import meteordevelopment.meteorclient.gui.utils.StarscriptTextBoxRenderer;
 import meteordevelopment.meteorclient.mixin.AbstractSignEditScreenAccessor;
 import meteordevelopment.meteorclient.settings.*;
 import meteordevelopment.meteorclient.systems.modules.Categories;
 import meteordevelopment.meteorclient.systems.modules.Module;
+import meteordevelopment.meteorclient.utils.misc.MeteorStarscript;
 import meteordevelopment.orbit.EventHandler;
+import meteordevelopment.starscript.Script;
 import meteordevelopment.starscript.StandardLib;
 import net.minecraft.block.entity.SignBlockEntity;
 import net.minecraft.client.gui.screen.ingame.AbstractSignEditScreen;
-import net.minecraft.network.packet.c2s.play.*;
-import meteordevelopment.meteorclient.gui.utils.StarscriptTextBoxRenderer;
-import meteordevelopment.meteorclient.utils.misc.MeteorStarscript;
-import meteordevelopment.starscript.Script;
-import meteordevelopment.meteorclient.gui.widgets.WWidget;
-import meteordevelopment.meteorclient.gui.widgets.pressable.WButton;
+import net.minecraft.network.packet.c2s.play.ClientCommandC2SPacket;
+import net.minecraft.network.packet.c2s.play.PlayerInteractBlockC2SPacket;
+import net.minecraft.network.packet.c2s.play.PlayerActionC2SPacket;
+import net.minecraft.network.packet.c2s.play.UpdateSignC2SPacket;
 import net.minecraft.text.Text;
 import net.minecraft.util.Hand;
 import net.minecraft.util.Util;
 import net.minecraft.util.hit.BlockHitResult;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Objects;
+import java.util.TimeZone;
 
 public class AutoSign extends Module {
 
@@ -182,7 +188,7 @@ public AutoSign() {
 
     @EventHandler
     private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
-        if (!(event.screen instanceof AbstractSignEditScreen)) return;
+        if (!(event.screen instanceof AbstractSignEditScreen)) {return;}
         if (applyingBack) {
             applyingBack = false;
             event.cancel();
@@ -207,8 +213,9 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
         if (frontEnabled.get()) {
             boolean written = false;
             for (Text text : sign.getFrontText().getMessages(false))
-                if (!Objects.equals(text.getString(), "") && !written)
+                if (!Objects.equals(text.getString(), "") && !written) {
                     written = true;
+                }
             if (overwrite.get() || !written) {
                 mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), true,
                     frontScripts.get(0) != null ? MeteorStarscript.run(frontScripts.get(0)) : "error",
@@ -231,21 +238,28 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
             }
 
             boolean wasSneaking = mc.player.isSneaking();
-            if (wasSneaking) mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY));
+            if (wasSneaking) {
+                mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY));
+            }
 
             BlockHitResult bhr = new BlockHitResult(sign.getPos().toCenterPos(), mc.player.getFacing().getOpposite(), sign.getPos(), false);
             mc.player.networkHandler.sendPacket(new PlayerInteractBlockC2SPacket(Hand.MAIN_HAND, bhr, 0));
 
-            if (wasSneaking) mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY));
+            if (wasSneaking) {
+                mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY));
+            }
 
-            if (offhand_swapped) mc.player.networkHandler.sendPacket(new PlayerActionC2SPacket(PlayerActionC2SPacket.Action.SWAP_ITEM_WITH_OFFHAND, mc.player.getBlockPos(), mc.player.getFacing()));
+            if (offhand_swapped) {
+                mc.player.networkHandler.sendPacket(new PlayerActionC2SPacket(PlayerActionC2SPacket.Action.SWAP_ITEM_WITH_OFFHAND, mc.player.getBlockPos(), mc.player.getFacing()));
+            }
         }
 
         if (backEnabled.get()) {
             boolean written = false;
             for (Text text : sign.getBackText().getMessages(false))
-                if (!Objects.equals(text.getString(), "") && !written)
+                if (!Objects.equals(text.getString(), "") && !written) {
                     written = true;
+                }
             if (overwrite.get() || !written) {
                 mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), false,
                     backScripts.get(0) != null ? MeteorStarscript.run(backScripts.get(0)) : "error",
@@ -265,8 +279,9 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
         }
 
         // When no sign side was updated open gui normally
-        if (updated)
+        if (updated) {
             event.cancel();
+        }
     }
 
     private void recompile(SettingGroup side, List<Script> sideScripts, int line) {
@@ -274,9 +289,10 @@ private void recompile(SettingGroup side, List<Script> sideScripts, int line) {
 
         Script script = MeteorStarscript.compile(compileLine);
 
-        if (sideScripts.size() <= line - 1)
+        if (sideScripts.size() <= line - 1) {
             sideScripts.add(script);
-        else
+        } else {
             sideScripts.set(line - 1, script);
+        }
     }
 }

From c030f1699c2b6e5ee05daafe601c983950c71f34 Mon Sep 17 00:00:00 2001
From: RealMuffinTime <realmuffintime@gmail.com>
Date: Wed, 22 May 2024 15:11:20 +0200
Subject: [PATCH 4/7] more code style improvements

---
 .../systems/modules/world/AutoSign.java       | 63 ++++++++++---------
 1 file changed, 34 insertions(+), 29 deletions(-)

diff --git a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
index eba8d2eb64..eb6a32a4d6 100644
--- a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
+++ b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
@@ -29,22 +29,16 @@
 import net.minecraft.util.Hand;
 import net.minecraft.util.Util;
 import net.minecraft.util.hit.BlockHitResult;
-import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
-import java.util.Objects;
 import java.util.TimeZone;
 
 public class AutoSign extends Module {
 
-    private boolean applyingBack = false;
-
     private final SettingGroup front = settings.createGroup("Front");
     private final SettingGroup back = settings.createGroup("Back");
     private final SettingGroup other = settings.createGroup("Other");
 
-    private final List<Script> frontScripts = new ArrayList<>();
-    private final List<Script> backScripts = new ArrayList<>();
-
     // 4 lines at front of sign
     public final Setting<Boolean> frontEnabled = front.add(new BoolSetting.Builder()
         .name("front-enabled")
@@ -57,7 +51,7 @@ public class AutoSign extends Module {
         .name("front-line-1")
         .description("Text in first line.")
         .defaultValue("{player}")
-        .onChanged(strings -> recompile(front, frontScripts, 1))
+        .onChanged(strings -> recompile(strings, 0, 0))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(frontEnabled::get)
         .build()
@@ -67,7 +61,7 @@ public class AutoSign extends Module {
         .name("front-line-2")
         .description("Text in second line.")
         .defaultValue("was here")
-        .onChanged(strings -> recompile(front, frontScripts, 2))
+        .onChanged(strings -> recompile(strings, 0, 1))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(frontEnabled::get)
         .build()
@@ -77,7 +71,7 @@ public class AutoSign extends Module {
         .name("front-line-3")
         .description("Text in third line.")
         .defaultValue("{date}")
-        .onChanged(strings -> recompile(front, frontScripts, 3))
+        .onChanged(strings -> recompile(strings, 0, 2))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(frontEnabled::get)
         .build()
@@ -87,7 +81,7 @@ public class AutoSign extends Module {
         .name("front-line-4")
         .description("Text in fourth line.")
         .defaultValue("{time}")
-        .onChanged(strings -> recompile(front, frontScripts, 4))
+        .onChanged(strings -> recompile(strings, 0, 3))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(frontEnabled::get)
         .build()
@@ -104,7 +98,7 @@ public class AutoSign extends Module {
     private final Setting<String> line1back = back.add(new StringSetting.Builder()
         .name("back-line-1")
         .description("Text in first line.")
-        .onChanged(strings -> recompile(back, backScripts, 1))
+        .onChanged(strings -> recompile(strings, 1, 0))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(backEnabled::get)
         .build()
@@ -115,7 +109,7 @@ public class AutoSign extends Module {
         .name("back-line-2")
         .description("Text in second line.")
         .defaultValue("It's MeteorTime.")
-        .onChanged(strings -> recompile(back, backScripts, 2))
+        .onChanged(strings -> recompile(strings, 1, 1))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(backEnabled::get)
         .build()
@@ -124,7 +118,7 @@ public class AutoSign extends Module {
     private final Setting<String> line3back = back.add(new StringSetting.Builder()
         .name("back-line-3")
         .description("Text in third line.")
-        .onChanged(strings -> recompile(back, backScripts, 3))
+        .onChanged(strings -> recompile(strings, 1, 2))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(backEnabled::get)
         .build()
@@ -133,7 +127,7 @@ public class AutoSign extends Module {
     private final Setting<String> line4back = back.add(new StringSetting.Builder()
         .name("back-line-4")
         .description("Text in fourth line.")
-        .onChanged(strings -> recompile(back, backScripts, 4))
+        .onChanged(strings -> recompile(strings, 1, 3))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(backEnabled::get)
         .build()
@@ -182,6 +176,10 @@ public WWidget getWidget(GuiTheme theme) {
         return list;
     }
 
+    private boolean applyingBack = false;
+    private final List<Script> frontScripts = Arrays.asList(new Script[4]);
+    private final List<Script> backScripts = Arrays.asList(new Script[4]);
+
     public AutoSign() {
         super(Categories.World, "auto-sign", "Automatically writes signs. Configure what to write dynamically using Starscript placeholders.");
     }
@@ -195,7 +193,7 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
             return;
         }
 
-        // apply custom format and timezone, not the nicest (temporary overwriting global date and time format)
+        // Apply custom format and timezone, not the nicest (temporary overwriting global date and time format)
         try {
             StandardLib.dateFormat.applyPattern(date.get());
             StandardLib.timeFormat.applyPattern(time.get());
@@ -211,11 +209,14 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
         SignBlockEntity sign = ((AbstractSignEditScreenAccessor) event.screen).getSign();
 
         if (frontEnabled.get()) {
+            // Check if front sign is already written
             boolean written = false;
-            for (Text text : sign.getFrontText().getMessages(false))
-                if (!Objects.equals(text.getString(), "") && !written) {
+            for (Text text : sign.getFrontText().getMessages(false)) {
+                if (!text.getString().isEmpty() && !written) {
                     written = true;
                 }
+            }
+
             if (overwrite.get() || !written) {
                 mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), true,
                     frontScripts.get(0) != null ? MeteorStarscript.run(frontScripts.get(0)) : "error",
@@ -254,12 +255,16 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
             }
         }
 
+        // TODO check if sign is editable
+
         if (backEnabled.get()) {
+            // Check if back sign is already written
             boolean written = false;
-            for (Text text : sign.getBackText().getMessages(false))
-                if (!Objects.equals(text.getString(), "") && !written) {
+            for (Text text : sign.getBackText().getMessages(false)) {
+                if (!text.getString().isEmpty() && !written) {
                     written = true;
                 }
+            }
             if (overwrite.get() || !written) {
                 mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), false,
                     backScripts.get(0) != null ? MeteorStarscript.run(backScripts.get(0)) : "error",
@@ -270,7 +275,7 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
             }
         }
 
-        // reset formating and timezones
+        // Reset formating and timezones
         StandardLib.dateFormat.applyPattern("dd. MM. yyyy");
         StandardLib.timeFormat.applyPattern("HH:mm");
         if (utcTimezone.get()) {
@@ -284,15 +289,15 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
         }
     }
 
-    private void recompile(SettingGroup side, List<Script> sideScripts, int line) {
-        String compileLine = (String) side.getByIndex(line).get();
-
-        Script script = MeteorStarscript.compile(compileLine);
-
-        if (sideScripts.size() <= line - 1) {
-            sideScripts.add(script);
+    private void recompile(String compileLine, int side, int line) {
+        List<Script> sideScripts;
+        if (side == 0) {
+            sideScripts = frontScripts;
         } else {
-            sideScripts.set(line - 1, script);
+            sideScripts = backScripts;
         }
+
+        Script script = MeteorStarscript.compile(compileLine);
+        sideScripts.set(line, script);
     }
 }

From d306d7330e528454283eda33cb736e86612d6058 Mon Sep 17 00:00:00 2001
From: RealMuffinTime <realmuffintime@gmail.com>
Date: Wed, 22 May 2024 15:15:15 +0200
Subject: [PATCH 5/7] remove date and timezone formating (in hope for
 starscript date and timezone formating)

---
 .../systems/modules/world/AutoSign.java       | 43 -------------------
 1 file changed, 43 deletions(-)

diff --git a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
index eb6a32a4d6..63e1457f98 100644
--- a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
+++ b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
@@ -18,7 +18,6 @@
 import meteordevelopment.meteorclient.utils.misc.MeteorStarscript;
 import meteordevelopment.orbit.EventHandler;
 import meteordevelopment.starscript.Script;
-import meteordevelopment.starscript.StandardLib;
 import net.minecraft.block.entity.SignBlockEntity;
 import net.minecraft.client.gui.screen.ingame.AbstractSignEditScreen;
 import net.minecraft.network.packet.c2s.play.ClientCommandC2SPacket;
@@ -31,7 +30,6 @@
 import net.minecraft.util.hit.BlockHitResult;
 import java.util.Arrays;
 import java.util.List;
-import java.util.TimeZone;
 
 public class AutoSign extends Module {
 
@@ -140,27 +138,6 @@ public class AutoSign extends Module {
         .defaultValue(false)
         .build());
 
-    private final Setting<String> date = other.add(new StringSetting.Builder()
-        .name("date-format")
-        .description("Format string for {date} object.")
-        .defaultValue("yyyy-MM-dd")
-        .build()
-    );
-
-    private final Setting<String> time = other.add(new StringSetting.Builder()
-        .name("time-format")
-        .description("Format string for {time} object.")
-        .defaultValue("HH:mm z")
-        .build()
-    );
-
-    private final Setting<Boolean> utcTimezone = other.add(new BoolSetting.Builder()
-        .name("UTC-timezone")
-        .description("Whether to use UTC or your local timezone.")
-        .defaultValue(true)
-        .build()
-    );
-
     @Override
     public WWidget getWidget(GuiTheme theme) {
         WHorizontalList list = theme.horizontalList();
@@ -193,18 +170,6 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
             return;
         }
 
-        // Apply custom format and timezone, not the nicest (temporary overwriting global date and time format)
-        try {
-            StandardLib.dateFormat.applyPattern(date.get());
-            StandardLib.timeFormat.applyPattern(time.get());
-        } catch (IllegalArgumentException e) {
-            error(e.getMessage());
-        }
-        if (utcTimezone.get()) {
-            StandardLib.dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
-            StandardLib.timeFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
-        }
-
         boolean updated = false;
         SignBlockEntity sign = ((AbstractSignEditScreenAccessor) event.screen).getSign();
 
@@ -275,14 +240,6 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
             }
         }
 
-        // Reset formating and timezones
-        StandardLib.dateFormat.applyPattern("dd. MM. yyyy");
-        StandardLib.timeFormat.applyPattern("HH:mm");
-        if (utcTimezone.get()) {
-            StandardLib.dateFormat.setTimeZone(TimeZone.getDefault());
-            StandardLib.timeFormat.setTimeZone(TimeZone.getDefault());
-        }
-
         // When no sign side was updated open gui normally
         if (updated) {
             event.cancel();

From 1ececfecf5b897dc8d6978e64f0342551d12d4e3 Mon Sep 17 00:00:00 2001
From: RealMuffinTime <realmuffintime@gmail.com>
Date: Fri, 24 May 2024 15:28:19 +0200
Subject: [PATCH 6/7] restructure module add warning if server does not support
 sign edit

---
 .../systems/modules/world/AutoSign.java       | 194 +++++++++++-------
 1 file changed, 122 insertions(+), 72 deletions(-)

diff --git a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
index 63e1457f98..c7bc52e3e8 100644
--- a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
+++ b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
@@ -6,6 +6,7 @@
 package meteordevelopment.meteorclient.systems.modules.world;
 
 import meteordevelopment.meteorclient.events.game.OpenScreenEvent;
+import meteordevelopment.meteorclient.events.packets.PacketEvent;
 import meteordevelopment.meteorclient.gui.GuiTheme;
 import meteordevelopment.meteorclient.gui.widgets.containers.WHorizontalList;
 import meteordevelopment.meteorclient.gui.widgets.pressable.WButton;
@@ -19,6 +20,7 @@
 import meteordevelopment.orbit.EventHandler;
 import meteordevelopment.starscript.Script;
 import net.minecraft.block.entity.SignBlockEntity;
+import net.minecraft.block.entity.SignText;
 import net.minecraft.client.gui.screen.ingame.AbstractSignEditScreen;
 import net.minecraft.network.packet.c2s.play.ClientCommandC2SPacket;
 import net.minecraft.network.packet.c2s.play.PlayerInteractBlockC2SPacket;
@@ -49,7 +51,7 @@ public class AutoSign extends Module {
         .name("front-line-1")
         .description("Text in first line.")
         .defaultValue("{player}")
-        .onChanged(strings -> recompile(strings, 0, 0))
+        .onChanged(strings -> recompile(strings, true, 0))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(frontEnabled::get)
         .build()
@@ -59,7 +61,7 @@ public class AutoSign extends Module {
         .name("front-line-2")
         .description("Text in second line.")
         .defaultValue("was here")
-        .onChanged(strings -> recompile(strings, 0, 1))
+        .onChanged(strings -> recompile(strings, true, 1))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(frontEnabled::get)
         .build()
@@ -69,7 +71,7 @@ public class AutoSign extends Module {
         .name("front-line-3")
         .description("Text in third line.")
         .defaultValue("{date}")
-        .onChanged(strings -> recompile(strings, 0, 2))
+        .onChanged(strings -> recompile(strings, true, 2))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(frontEnabled::get)
         .build()
@@ -79,7 +81,7 @@ public class AutoSign extends Module {
         .name("front-line-4")
         .description("Text in fourth line.")
         .defaultValue("{time}")
-        .onChanged(strings -> recompile(strings, 0, 3))
+        .onChanged(strings -> recompile(strings, true, 3))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(frontEnabled::get)
         .build()
@@ -96,7 +98,7 @@ public class AutoSign extends Module {
     private final Setting<String> line1back = back.add(new StringSetting.Builder()
         .name("back-line-1")
         .description("Text in first line.")
-        .onChanged(strings -> recompile(strings, 1, 0))
+        .onChanged(strings -> recompile(strings, false, 0))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(backEnabled::get)
         .build()
@@ -107,7 +109,7 @@ public class AutoSign extends Module {
         .name("back-line-2")
         .description("Text in second line.")
         .defaultValue("It's MeteorTime.")
-        .onChanged(strings -> recompile(strings, 1, 1))
+        .onChanged(strings -> recompile(strings, false, 1))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(backEnabled::get)
         .build()
@@ -116,7 +118,7 @@ public class AutoSign extends Module {
     private final Setting<String> line3back = back.add(new StringSetting.Builder()
         .name("back-line-3")
         .description("Text in third line.")
-        .onChanged(strings -> recompile(strings, 1, 2))
+        .onChanged(strings -> recompile(strings, false, 2))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(backEnabled::get)
         .build()
@@ -125,7 +127,7 @@ public class AutoSign extends Module {
     private final Setting<String> line4back = back.add(new StringSetting.Builder()
         .name("back-line-4")
         .description("Text in fourth line.")
-        .onChanged(strings -> recompile(strings, 1, 3))
+        .onChanged(strings -> recompile(strings, false, 3))
         .renderer(StarscriptTextBoxRenderer.class)
         .visible(backEnabled::get)
         .build()
@@ -153,7 +155,11 @@ public WWidget getWidget(GuiTheme theme) {
         return list;
     }
 
-    private boolean applyingBack = false;
+    private boolean signPlaced = false;
+    private boolean signUpdated = false;
+    private boolean frontToWrite;
+    private boolean backToWrite;
+    private int expectedPacket = 0;
     private final List<Script> frontScripts = Arrays.asList(new Script[4]);
     private final List<Script> backScripts = Arrays.asList(new Script[4]);
 
@@ -161,94 +167,138 @@ public AutoSign() {
         super(Categories.World, "auto-sign", "Automatically writes signs. Configure what to write dynamically using Starscript placeholders.");
     }
 
+    @EventHandler
+    private void onSendPacket(PacketEvent.Send event) {
+        if (!(event.packet instanceof PlayerInteractBlockC2SPacket)) return;
+        if (expectedPacket == 1) {
+            // we send this packet in restartInteraction
+            expectedPacket = 2;
+        } else if (expectedPacket == 2) {
+            // as we already received restartInteraction packet
+            // but the expected packet was not reset by onOpenScreen
+            // we cant apply back sign
+            backToWrite = false;
+            signPlaced = false;
+            warning("It seems like that this server does not support sign editing, disabling back sign writing is recommended.");
+        }
+    }
+
     @EventHandler
     private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
         if (!(event.screen instanceof AbstractSignEditScreen)) {return;}
-        if (applyingBack) {
-            applyingBack = false;
-            event.cancel();
-            return;
-        }
 
-        boolean updated = false;
         SignBlockEntity sign = ((AbstractSignEditScreenAccessor) event.screen).getSign();
 
-        if (frontEnabled.get()) {
-            // Check if front sign is already written
-            boolean written = false;
-            for (Text text : sign.getFrontText().getMessages(false)) {
-                if (!text.getString().isEmpty() && !written) {
-                    written = true;
-                }
-            }
+        if (!signPlaced) {
+            signPlaced = true;
+            frontToWrite = frontEnabled.get();
+            backToWrite = backEnabled.get();
+        }
 
-            if (overwrite.get() || !written) {
-                mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), true,
-                    frontScripts.get(0) != null ? MeteorStarscript.run(frontScripts.get(0)) : "error",
-                    frontScripts.get(1) != null ? MeteorStarscript.run(frontScripts.get(1)) : "error",
-                    frontScripts.get(2) != null ? MeteorStarscript.run(frontScripts.get(2)) : "error",
-                    frontScripts.get(3) != null ? MeteorStarscript.run(frontScripts.get(3)) : "error"));
-                updated = true;
+        if (frontToWrite) {
+            boolean updated = writeSign(sign, true);
+            if (!signUpdated && updated) {
+                signUpdated = true;
+            }
+            frontToWrite = false;
+            if (backToWrite) {
+                // onOpenScreen will be called a second time if server accepts interaction
+                restartInteraction(sign);
+            }
+        } else if (backToWrite) {
+            boolean updated = writeSign(sign, false);
+            if (!signUpdated && updated) {
+                signUpdated = true;
+            }
+            backToWrite = false;
+            if (expectedPacket == 2) {
+                // Server accepted sign edit
+                expectedPacket = 0;
             }
         }
 
-        // Start a second sign interaction (if applicable) to apply second side of sign
-        if (updated && backEnabled.get()) {
-            applyingBack = true;
+        if (!frontToWrite && !backToWrite) {
+            signPlaced = false;
+        }
 
-            // If sign was placed with offhand
-            boolean offhand_swapped = false;
-            if (!mc.player.getMainHandStack().getTranslationKey().endsWith("sign") && !mc.player.getMainHandStack().getTranslationKey().endsWith("air")) {
-                mc.player.networkHandler.sendPacket(new PlayerActionC2SPacket(PlayerActionC2SPacket.Action.SWAP_ITEM_WITH_OFFHAND, mc.player.getBlockPos(), mc.player.getFacing()));
-                offhand_swapped = true;
-            }
+        // Cancel GUI only when something was updated
+        if (signUpdated || signPlaced) {
+            signUpdated = false;
+            event.cancel();
+        }
+    }
+
+    private boolean writeSign(SignBlockEntity sign, boolean front) {
+        List<Script> script;
+        SignText signText;
+        if (front) {
+            script = frontScripts;
+            signText = sign.getFrontText();
+        } else {
+            script = backScripts;
+            signText = sign.getBackText();
+        }
 
-            boolean wasSneaking = mc.player.isSneaking();
-            if (wasSneaking) {
-                mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY));
+        // Check if side of sign is already written
+        boolean written = false;
+        for (Text text : signText.getMessages(false)) {
+            if (!text.getString().isEmpty() && !written) {
+                written = true;
             }
+        }
 
-            BlockHitResult bhr = new BlockHitResult(sign.getPos().toCenterPos(), mc.player.getFacing().getOpposite(), sign.getPos(), false);
-            mc.player.networkHandler.sendPacket(new PlayerInteractBlockC2SPacket(Hand.MAIN_HAND, bhr, 0));
+        if (overwrite.get() || !written) {
+            String line0 = script.get(0) != null ? MeteorStarscript.run(script.get(0)) : "error";
+            String line1 = script.get(1) != null ? MeteorStarscript.run(script.get(1)) : "error";
+            String line2 = script.get(2) != null ? MeteorStarscript.run(script.get(2)) : "error";
+            String line3 = script.get(3) != null ? MeteorStarscript.run(script.get(3)) : "error";
+            mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), front,
+                line0 != null ? line0 : "error",
+                line1 != null ? line1 : "error",
+                line2 != null ? line2 : "error",
+                line3 != null ? line3 : "error"));
+            return true;
+        }
+        return false;
+    }
 
-            if (wasSneaking) {
-                mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY));
-            }
+    // Try a new sign interaction
+    private void restartInteraction(SignBlockEntity sign) {
 
-            if (offhand_swapped) {
-                mc.player.networkHandler.sendPacket(new PlayerActionC2SPacket(PlayerActionC2SPacket.Action.SWAP_ITEM_WITH_OFFHAND, mc.player.getBlockPos(), mc.player.getFacing()));
-            }
+        // If sign was placed with offhand
+        boolean offhand_swapped = false;
+        if (!mc.player.getMainHandStack().getTranslationKey().endsWith("sign") && !mc.player.getMainHandStack().getTranslationKey().endsWith("air")) {
+            mc.player.networkHandler.sendPacket(new PlayerActionC2SPacket(PlayerActionC2SPacket.Action.SWAP_ITEM_WITH_OFFHAND, mc.player.getBlockPos(), mc.player.getFacing()));
+            offhand_swapped = true;
         }
 
-        // TODO check if sign is editable
+        // Avoid sneaking during interaction
+        boolean wasSneaking = mc.player.isSneaking();
+        if (wasSneaking) {
+            mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY));
+        }
+        BlockHitResult bhr = new BlockHitResult(sign.getPos().toCenterPos(), mc.player.getFacing().getOpposite(), sign.getPos(), false);
 
-        if (backEnabled.get()) {
-            // Check if back sign is already written
-            boolean written = false;
-            for (Text text : sign.getBackText().getMessages(false)) {
-                if (!text.getString().isEmpty() && !written) {
-                    written = true;
-                }
-            }
-            if (overwrite.get() || !written) {
-                mc.player.networkHandler.sendPacket(new UpdateSignC2SPacket(sign.getPos(), false,
-                    backScripts.get(0) != null ? MeteorStarscript.run(backScripts.get(0)) : "error",
-                    backScripts.get(1) != null ? MeteorStarscript.run(backScripts.get(1)) : "error",
-                    backScripts.get(2) != null ? MeteorStarscript.run(backScripts.get(2)) : "error",
-                    backScripts.get(3) != null ? MeteorStarscript.run(backScripts.get(3)) : "error"));
-                updated = true;
-            }
+        // expectedPacket shenanigans are used to identify if server accepted the sign edit
+        expectedPacket = 1;
+
+        // We can only improve chances, that this interaction triggers sign edit
+        // Since in the end the server decides, what to do with this interaction (as far as I know...)
+        // (if it allows sign edit or as example instead places a block)
+        mc.player.networkHandler.sendPacket(new PlayerInteractBlockC2SPacket(Hand.MAIN_HAND, bhr, 0));
+
+        if (wasSneaking) {
+            mc.player.networkHandler.sendPacket(new ClientCommandC2SPacket(mc.player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY));
         }
 
-        // When no sign side was updated open gui normally
-        if (updated) {
-            event.cancel();
+        if (offhand_swapped) {
+            mc.player.networkHandler.sendPacket(new PlayerActionC2SPacket(PlayerActionC2SPacket.Action.SWAP_ITEM_WITH_OFFHAND, mc.player.getBlockPos(), mc.player.getFacing()));
         }
     }
 
-    private void recompile(String compileLine, int side, int line) {
+    private void recompile(String compileLine, boolean front, int line) {
         List<Script> sideScripts;
-        if (side == 0) {
+        if (front) {
             sideScripts = frontScripts;
         } else {
             sideScripts = backScripts;

From 5839aae69f19a0186b784c57ff7783fb4a8a9e64 Mon Sep 17 00:00:00 2001
From: RealMuffinTime <realmuffintime@gmail.com>
Date: Fri, 31 May 2024 19:34:49 +0200
Subject: [PATCH 7/7] add warning if second sign write is initially placed sign
 fix expected packet reset

---
 .../systems/modules/world/AutoSign.java       | 33 +++++++++++--------
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
index c7bc52e3e8..1c8ce3a844 100644
--- a/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
+++ b/src/main/java/meteordevelopment/meteorclient/systems/modules/world/AutoSign.java
@@ -30,6 +30,7 @@
 import net.minecraft.util.Hand;
 import net.minecraft.util.Util;
 import net.minecraft.util.hit.BlockHitResult;
+import net.minecraft.util.math.BlockPos;
 import java.util.Arrays;
 import java.util.List;
 
@@ -155,7 +156,7 @@ public WWidget getWidget(GuiTheme theme) {
         return list;
     }
 
-    private boolean signPlaced = false;
+    private BlockPos signPlaced = null;
     private boolean signUpdated = false;
     private boolean frontToWrite;
     private boolean backToWrite;
@@ -177,9 +178,12 @@ private void onSendPacket(PacketEvent.Send event) {
             // as we already received restartInteraction packet
             // but the expected packet was not reset by onOpenScreen
             // we cant apply back sign
+            expectedPacket = 0;
             backToWrite = false;
-            signPlaced = false;
-            warning("It seems like that this server does not support sign editing, disabling back sign writing is recommended.");
+            signPlaced = null;
+            if (backEnabled.get()) {
+                warning("It seems like that this server does not support sign editing, disabling back sign writing is recommended.");
+            }
         }
     }
 
@@ -189,15 +193,15 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
 
         SignBlockEntity sign = ((AbstractSignEditScreenAccessor) event.screen).getSign();
 
-        if (!signPlaced) {
-            signPlaced = true;
+        if (signPlaced == null) {
+            signPlaced = sign.getPos();
             frontToWrite = frontEnabled.get();
             backToWrite = backEnabled.get();
         }
 
         if (frontToWrite) {
             boolean updated = writeSign(sign, true);
-            if (!signUpdated && updated) {
+            if (updated) {
                 signUpdated = true;
             }
             frontToWrite = false;
@@ -206,8 +210,12 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
                 restartInteraction(sign);
             }
         } else if (backToWrite) {
+            // check if second sign interaction is for the same sign initially placed
+            if (!signPlaced.equals(sign.getPos())) {
+                warning("It seems like that this server does not support sign editing, disabling back sign writing is recommended.");
+            }
             boolean updated = writeSign(sign, false);
-            if (!signUpdated && updated) {
+            if (updated) {
                 signUpdated = true;
             }
             backToWrite = false;
@@ -218,11 +226,11 @@ private void onOpenScreen(OpenScreenEvent event) throws InterruptedException {
         }
 
         if (!frontToWrite && !backToWrite) {
-            signPlaced = false;
+            signPlaced = null;
         }
 
         // Cancel GUI only when something was updated
-        if (signUpdated || signPlaced) {
+        if (signUpdated || signPlaced != null) {
             signUpdated = false;
             event.cancel();
         }
@@ -263,6 +271,9 @@ private boolean writeSign(SignBlockEntity sign, boolean front) {
     }
 
     // Try a new sign interaction
+    // We can only improve chances, that this interaction triggers sign edit
+    // Since in the end the server decides, what to do with this interaction (as far as I know...)
+    // (if it allows sign edit or as example instead places a block)
     private void restartInteraction(SignBlockEntity sign) {
 
         // If sign was placed with offhand
@@ -281,10 +292,6 @@ private void restartInteraction(SignBlockEntity sign) {
 
         // expectedPacket shenanigans are used to identify if server accepted the sign edit
         expectedPacket = 1;
-
-        // We can only improve chances, that this interaction triggers sign edit
-        // Since in the end the server decides, what to do with this interaction (as far as I know...)
-        // (if it allows sign edit or as example instead places a block)
         mc.player.networkHandler.sendPacket(new PlayerInteractBlockC2SPacket(Hand.MAIN_HAND, bhr, 0));
 
         if (wasSneaking) {